[GitHub] incubator-tephra issue #37: TEPHRA-223 Encapsulate the two data structures u...

[poornachandra <gi...@git.apache.org>]

Github user poornachandra commented on the issue:

    https://github.com/apache/incubator-tephra/pull/37
  
    > Does the added synchronization add performance overhead?
    
    Extra synchronization is added in five places in this PR -
    1. canCommit() - when transaction is not in in-progress  list
    
    2. Emitting metrics - metrics are emitted every 10 seconds
    
    3. getInvalidSize() - called when Thrift endpoint is invoked by user or by monitoring scripts
    
    4. and 5. getExcludedListSize() and logStatistics() - these methods are used in test or unused
    
    The only significant usage is by canCommit() when the committing transaction is not in the in-progress list. I think this overhead is acceptable since we now sort the invalid list only when creating a transaction, as opposed to sorting it whenever the list changed (like we did earlier).
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---