You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "FMX (via GitHub)" <gi...@apache.org> on 2023/02/14 06:21:32 UTC
[GitHub] [incubator-celeborn] FMX opened a new pull request, #1235: [CELEBORN-300] fix a bug about non-leader master try to update partition size.
FMX opened a new pull request, #1235:
URL: https://github.com/apache/incubator-celeborn/pull/1235
### What changes were proposed in this pull request?
If a master is not a leader, it won't try to update the partition size.
### Why are the changes needed?
To reduce log size.
### Does this PR introduce _any_ user-facing change?
NO.
### How was this patch tested?
UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1235: [CELEBORN-300] fix a bug about non-leader master try to update partition size.
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1235:
URL: https://github.com/apache/incubator-celeborn/pull/1235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1235: [CELEBORN-300] fix a bug about non-leader master try to update partition size.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1235:
URL: https://github.com/apache/incubator-celeborn/pull/1235#issuecomment-1429193196
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1235?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1235](https://codecov.io/gh/apache/incubator-celeborn/pull/1235?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e26c450) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/4fb5b3d5479292eea866ca0123b3360e8568fa23?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4fb5b3d) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1235 +/- ##
============================================
- Coverage 27.24% 27.21% -0.03%
+ Complexity 808 804 -4
============================================
Files 212 212
Lines 17997 17999 +2
Branches 1964 1964
============================================
- Hits 4902 4896 -6
- Misses 12772 12776 +4
- Partials 323 327 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1235?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/celeborn/service/deploy/master/Master.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1235?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvbWFzdGVyL01hc3Rlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1235?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `69.27% <0.00%> (-2.45%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org