[GitHub] [couchdb] iilyak commented on a diff in pull request #4089: Try using rebar3

[GitBox <gi...@apache.org>]

iilyak commented on code in PR #4089:
URL: https://github.com/apache/couchdb/pull/4089#discussion_r920210474


##########
build-aux/couchdb-build-release.sh:
##########
@@ -18,17 +18,17 @@ CURRENT_BRANCH=`git rev-parse --abbrev-ref HEAD`
 
 # copy sources over
 git archive ${CURRENT_BRANCH} | tar -xC ${REL_DIR}/ -f -
-cd src/
+cd _build/default/lib/
 for repo in *; do
   cd ${repo}
   if [ -d ".git" ]; then
-    mkdir -p ../../${REL_DIR}/src/${repo}
+    mkdir -p ../../../../${REL_DIR}/apps/${repo}

Review Comment:
   To improve readability let's set a variable and use that instead.
   
   ```
   SELF_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
   COUCHDB_ROOT="${SELF_DIR}/.."
   ```
   
   You would need to update `#!/bin/sh -e` in the begining of the script to use bash in order to make it work. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org