[GitHub] [iotdb] SpriCoder commented on a diff in pull request #8946: Formatting getOrCreatePartitionTables log

["SpriCoder (via GitHub)" <gi...@apache.org>]

SpriCoder commented on code in PR #8946:
URL: https://github.com/apache/iotdb/pull/8946#discussion_r1092797151


##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/ConfigManager.java:
##########
@@ -651,14 +651,51 @@ public TSchemaPartitionTableResp getOrCreateSchemaPartition(PathPatternTree patt
         partitionManager.getOrCreateSchemaPartition(getOrCreateSchemaPartitionPlan);
     resp = queryResult.convertToRpcSchemaPartitionTableResp();
 
-    LOGGER.debug(
-        "GetOrCreateSchemaPartition receive devicePaths: {}, return TSchemaPartitionResp: {}",
-        devicePaths,
-        resp);
+    if (CONF.isPartitionDebugEnabled()) {
+      printNewCreatedSchemaPartition(devicePaths, resp);
+    }
 
     return resp;
   }
 
+  private void printNewCreatedSchemaPartition(
+      List<String> devicePaths, TSchemaPartitionTableResp resp) {
+    StringBuilder devicePathString = new StringBuilder("{");

Review Comment:
   Please modify `\n` to `%n` to adapt different system.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org