You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/13 07:36:49 UTC
[GitHub] [flink] twalthr opened a new pull request #10838:
[hotfix][table-common] Simplify formatted exceptions
twalthr opened a new pull request #10838: [hotfix][table-common] Simplify formatted exceptions
URL: https://github.com/apache/flink/pull/10838
## What is the purpose of the change
Makes formatted exceptions easier and helps by providing some simple coding guidelines in the JavaDocs.
## Brief change log
- New constructors for `TableException` and `ValidationException`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? JavaDocs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10838:
[hotfix][table-common] Simplify formatted exceptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10838: [hotfix][table-common] Simplify formatted exceptions
URL: https://github.com/apache/flink/pull/10838#issuecomment-573544312
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d7cd665ed96239643ccbc81bafacc8fd0e12e80",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4282",
"triggerID" : "6d7cd665ed96239643ccbc81bafacc8fd0e12e80",
"triggerType" : "PUSH"
}, {
"hash" : "6d7cd665ed96239643ccbc81bafacc8fd0e12e80",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/144107161",
"triggerID" : "6d7cd665ed96239643ccbc81bafacc8fd0e12e80",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6d7cd665ed96239643ccbc81bafacc8fd0e12e80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144107161) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4282)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10838: [hotfix][table-common]
Simplify formatted exceptions
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10838: [hotfix][table-common] Simplify formatted exceptions
URL: https://github.com/apache/flink/pull/10838#issuecomment-573541506
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6d7cd665ed96239643ccbc81bafacc8fd0e12e80 (Mon Jan 13 07:40:27 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10838:
[hotfix][table-common] Simplify formatted exceptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10838: [hotfix][table-common] Simplify formatted exceptions
URL: https://github.com/apache/flink/pull/10838#issuecomment-573544312
<!--
Meta data
Hash:6d7cd665ed96239643ccbc81bafacc8fd0e12e80 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4282 TriggerType:PUSH TriggerID:6d7cd665ed96239643ccbc81bafacc8fd0e12e80
Hash:6d7cd665ed96239643ccbc81bafacc8fd0e12e80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144107161 TriggerType:PUSH TriggerID:6d7cd665ed96239643ccbc81bafacc8fd0e12e80
-->
## CI report:
* 6d7cd665ed96239643ccbc81bafacc8fd0e12e80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144107161) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4282)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10838:
[hotfix][table-common] Simplify formatted exceptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10838: [hotfix][table-common] Simplify formatted exceptions
URL: https://github.com/apache/flink/pull/10838#issuecomment-573544312
<!--
Meta data
Hash:6d7cd665ed96239643ccbc81bafacc8fd0e12e80 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4282 TriggerType:PUSH TriggerID:6d7cd665ed96239643ccbc81bafacc8fd0e12e80
Hash:6d7cd665ed96239643ccbc81bafacc8fd0e12e80 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144107161 TriggerType:PUSH TriggerID:6d7cd665ed96239643ccbc81bafacc8fd0e12e80
-->
## CI report:
* 6d7cd665ed96239643ccbc81bafacc8fd0e12e80 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144107161) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4282)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10838: [hotfix][table-common]
Simplify formatted exceptions
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10838: [hotfix][table-common] Simplify formatted exceptions
URL: https://github.com/apache/flink/pull/10838#issuecomment-573544312
<!--
Meta data
Hash:6d7cd665ed96239643ccbc81bafacc8fd0e12e80 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:6d7cd665ed96239643ccbc81bafacc8fd0e12e80
-->
## CI report:
* 6d7cd665ed96239643ccbc81bafacc8fd0e12e80 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr commented on issue #10838: [hotfix][table-common]
Simplify formatted exceptions
Posted by GitBox <gi...@apache.org>.
twalthr commented on issue #10838: [hotfix][table-common] Simplify formatted exceptions
URL: https://github.com/apache/flink/pull/10838#issuecomment-573595958
I'm fine with a builder approach. This also allows us to include error codes and other properties (such as severity) in the future. I will update the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on issue #10838: [hotfix][table-common]
Simplify formatted exceptions
Posted by GitBox <gi...@apache.org>.
dawidwys commented on issue #10838: [hotfix][table-common] Simplify formatted exceptions
URL: https://github.com/apache/flink/pull/10838#issuecomment-573546069
This solution has one caveat that it is not very intuitive. I think we all (java coders) are used to passing the exception at the end. I'm afraid this solution might be surprising for a lot of newcomers.
How about we rather add a builder:
```
public static TableExceptionBuilder tableException(String format, Object... args);
class TableExceptionBuilder {
TableException cause(Throwable cause);
TableException build();
}
```
Or if we want to get rid off the `build` method:
```
class TableException {
public static TableException tableException(String format, Object... args);
public TableException cause(Throwable cause) {
return new TableException(getMessage(), cause);
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10838:
[hotfix][table-common] Simplify formatted exceptions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10838: [hotfix][table-common] Simplify formatted exceptions
URL: https://github.com/apache/flink/pull/10838#issuecomment-573544312
<!--
Meta data
Hash:6d7cd665ed96239643ccbc81bafacc8fd0e12e80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4282 TriggerType:PUSH TriggerID:6d7cd665ed96239643ccbc81bafacc8fd0e12e80
Hash:6d7cd665ed96239643ccbc81bafacc8fd0e12e80 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144107161 TriggerType:PUSH TriggerID:6d7cd665ed96239643ccbc81bafacc8fd0e12e80
-->
## CI report:
* 6d7cd665ed96239643ccbc81bafacc8fd0e12e80 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144107161) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4282)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services