You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@aurora.apache.org by ke...@apache.org on 2013/12/04 21:18:47 UTC

git commit: Document ASF review process.

Updated Branches:
  refs/heads/kts/asf-process [created] 3a1b4d80b


Document ASF review process.


Project: http://git-wip-us.apache.org/repos/asf/incubator-aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-aurora/commit/3a1b4d80
Tree: http://git-wip-us.apache.org/repos/asf/incubator-aurora/tree/3a1b4d80
Diff: http://git-wip-us.apache.org/repos/asf/incubator-aurora/diff/3a1b4d80

Branch: refs/heads/kts/asf-process
Commit: 3a1b4d80b7ca6ff4c6c5d5737eba4caca7f16716
Parents: c72c92c
Author: Kevin Sweeney <ks...@twitter.com>
Authored: Wed Dec 4 11:44:40 2013 -0800
Committer: Kevin Sweeney <ks...@twitter.com>
Committed: Wed Dec 4 12:18:13 2013 -0800

----------------------------------------------------------------------
 .gitignore           |  2 +-
 .reviewboardrc       |  2 ++
 docs/contributing.md | 28 ++++++++++++++++++++++++++++
 rbt                  | 11 +++++++++++
 4 files changed, 42 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/3a1b4d80/.gitignore
----------------------------------------------------------------------
diff --git a/.gitignore b/.gitignore
index 3731eeb..8f66585 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,9 +6,9 @@
 .coverage
 .gradle/
 .pants.*
-.reviewboardrc
 .vagrant/
 build/
+build-support/rbtools/
 dist/
 gradle-app.setting
 out/

http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/3a1b4d80/.reviewboardrc
----------------------------------------------------------------------
diff --git a/.reviewboardrc b/.reviewboardrc
new file mode 100644
index 0000000..f11679f
--- /dev/null
+++ b/.reviewboardrc
@@ -0,0 +1,2 @@
+REPOSITORY = "aurora"
+REVIEWBOARD_URL = "https://reviews.apache.org"

http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/3a1b4d80/docs/contributing.md
----------------------------------------------------------------------
diff --git a/docs/contributing.md b/docs/contributing.md
new file mode 100644
index 0000000..1bb0c9a
--- /dev/null
+++ b/docs/contributing.md
@@ -0,0 +1,28 @@
+Getting your ReviewBoard Account
+--------------------------------
+Go to https://reviews.apache.org and create an account.
+
+Setting up your ReviewBoard Environment
+---------------------------------------
+Run `./rbt status`. The first time this runs it will bootstrap and you will be asked to login.
+Subsequent runs will cache your login credentials.
+
+Submitting a Patch for Review (Committers)
+------------------------------------------
+First, push your feature branch, e.g.
+
+    git push apache kevints/clairvoyance
+
+Now post the review with `rbt`, fill out the fields in your browser and hit Publish.
+
+    ./rbt post -o -g
+
+Updating an Existing Review (Committers)
+----------------------------------------
+First, push your updated feature branch, e.g.
+
+    git push apache kevints/clairvoyance
+
+Now update the existing review, fill out the fields in your browser and hit Publish.
+
+    ./rbt post -o -r <RB_ID>

http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/3a1b4d80/rbt
----------------------------------------------------------------------
diff --git a/rbt b/rbt
new file mode 100755
index 0000000..0732e9b
--- /dev/null
+++ b/rbt
@@ -0,0 +1,11 @@
+#!/bin/sh
+# Wrapper script for self-bootstrapping rbt.
+# TODO(ksweeney): Use ./pants py here instead of virtualenv.
+if ! [ -d build-support/rbtools ]; then
+  echo Bootstrapping rbtools
+  virtualenv build-support/rbtools
+  source build-support/rbtools/bin/activate
+  pip install RBTools==0.5
+fi
+source build-support/rbtools/bin/activate
+exec rbt "$@"