You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/04 15:29:29 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request #14124: [build] Upgrade failsafe (fix JDK17 build)
nicoloboschi opened a new pull request #14124:
URL: https://github.com/apache/pulsar/pull/14124
### Motivation
Current failsafe version is outdated (2019).
Java compiler fails due to a weird exception `ClosedFileSystemException`. The cause is the usage of failsafe (I haven't found any doc/issue on the failsafe repo, but still)
Upgrading failsafe to the latest version makes the compiler happy
### Modifications
* Upgrade failsafe from 2.3.1 to 3.2.0 - also changed the groupId to the newest one
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #14124: [build] Upgrade failsafe (fix JDK17 build)
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #14124:
URL: https://github.com/apache/pulsar/pull/14124#discussion_r799588623
##########
File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/sources/AvroKafkaSourceTest.java
##########
@@ -19,11 +19,11 @@
package org.apache.pulsar.tests.integration.io.sources;
import com.google.gson.Gson;
+import dev.failsafe.Failsafe;
Review comment:
Can we move to Awaiatility?
Also, are we depending on the classes of a maven plugin ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #14124: [build] Remove net.jodah.failsafe dependency (fix JDK17 build)
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #14124:
URL: https://github.com/apache/pulsar/pull/14124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a change in pull request #14124: [build] Upgrade failsafe (fix JDK17 build)
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #14124:
URL: https://github.com/apache/pulsar/pull/14124#discussion_r799627734
##########
File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/sources/AvroKafkaSourceTest.java
##########
@@ -19,11 +19,11 @@
package org.apache.pulsar.tests.integration.io.sources;
import com.google.gson.Gson;
+import dev.failsafe.Failsafe;
Review comment:
good idea. I pushed the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org