You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@spark.apache.org by "Martin Grund (Jira)" <ji...@apache.org> on 2023/01/06 09:03:00 UTC

[jira] [Commented] (SPARK-41910) Remove `optional` notation in proto

    [ https://issues.apache.org/jira/browse/SPARK-41910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655336#comment-17655336 ] 

Martin Grund commented on SPARK-41910:
--------------------------------------

Didn't we just have the discussion on why we wanted to use optional? In particular for scalar values that have a default value?

> Remove `optional` notation in proto
> -----------------------------------
>
>                 Key: SPARK-41910
>                 URL: https://issues.apache.org/jira/browse/SPARK-41910
>             Project: Spark
>          Issue Type: Sub-task
>          Components: Connect
>    Affects Versions: 3.4.0
>            Reporter: Rui Wang
>            Priority: Major
>
> Every field in proto3 has a default value. We should revisit existing proto field to understand if the default value can be used without tell the field is set and not set, and remove `optional` as much as possible from Spark Connect proto surface.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org