You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ye...@apache.org on 2011/05/21 12:32:00 UTC
svn commit: r1125662 - in /poi/trunk/src:
examples/src/org/apache/poi/xssf/usermodel/examples/ScatterChart.java
java/org/apache/poi/ss/util/CellRangeAddress.java
Author: yegor
Date: Sat May 21 10:31:59 2011
New Revision: 1125662
URL: http://svn.apache.org/viewvc?rev=1125662&view=rev
Log:
Bug 51196: more progress with chart api
Modified:
poi/trunk/src/examples/src/org/apache/poi/xssf/usermodel/examples/ScatterChart.java
poi/trunk/src/java/org/apache/poi/ss/util/CellRangeAddress.java
Modified: poi/trunk/src/examples/src/org/apache/poi/xssf/usermodel/examples/ScatterChart.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/examples/src/org/apache/poi/xssf/usermodel/examples/ScatterChart.java?rev=1125662&r1=1125661&r2=1125662&view=diff
==============================================================================
--- poi/trunk/src/examples/src/org/apache/poi/xssf/usermodel/examples/ScatterChart.java (original)
+++ poi/trunk/src/examples/src/org/apache/poi/xssf/usermodel/examples/ScatterChart.java Sat May 21 10:31:59 2011
@@ -37,7 +37,7 @@ public class ScatterChart {
public static void main(String[]args) throws Exception {
Workbook wb = new XSSFWorkbook();
CreationHelper creationHelper = wb.getCreationHelper();
- Sheet sheet = wb.createSheet("new sheet");
+ Sheet sheet = wb.createSheet("Sheet 1");
final int NUM_OF_ROWS = 3;
final int NUM_OF_COLUMNS = 10;
@@ -57,7 +57,7 @@ public class ScatterChart {
Chart chart = drawing.createChart(anchor);
ChartLegend legend = chart.getOrCreateLegend();
- legend.setPosition(LegendPosition.RIGHT);
+ legend.setPosition(LegendPosition.TOP_RIGHT);
ScatterChartData data = chart.getChartDataFactory().createScatterChartData();
@@ -65,12 +65,12 @@ public class ScatterChart {
ValueAxis leftAxis = chart.getChartAxisFactory().createValueAxis(AxisPosition.LEFT);
ScatterChartSerie firstSerie = data.addSerie();
- firstSerie.setXValues(sheet, new CellRangeAddress(0, 0, NUM_OF_COLUMNS + 1, NUM_OF_COLUMNS + 1));
- firstSerie.setYValues(sheet, new CellRangeAddress(1, 1, NUM_OF_COLUMNS + 1, NUM_OF_COLUMNS + 1));
+ firstSerie.setXValues(sheet, new CellRangeAddress(0, 0, 0, NUM_OF_COLUMNS - 1));
+ firstSerie.setYValues(sheet, new CellRangeAddress(1, 1, 0, NUM_OF_COLUMNS - 1));
ScatterChartSerie secondSerie = data.addSerie();
- secondSerie.setXValues(sheet, new CellRangeAddress(0, 0, NUM_OF_COLUMNS + 1, NUM_OF_COLUMNS + 1));
- secondSerie.setYValues(sheet, new CellRangeAddress(2, 2, NUM_OF_COLUMNS + 1, NUM_OF_COLUMNS + 1));
+ secondSerie.setXValues(sheet, new CellRangeAddress(0, 0, 0, NUM_OF_COLUMNS - 1));
+ secondSerie.setYValues(sheet, new CellRangeAddress(2, 2, 0, NUM_OF_COLUMNS - 1));
chart.plot(data, bottomAxis, leftAxis);
Modified: poi/trunk/src/java/org/apache/poi/ss/util/CellRangeAddress.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/util/CellRangeAddress.java?rev=1125662&r1=1125661&r2=1125662&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/util/CellRangeAddress.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/util/CellRangeAddress.java Sat May 21 10:31:59 2011
@@ -17,6 +17,7 @@
package org.apache.poi.ss.util;
+import org.apache.poi.ss.formula.SheetNameFormatter;
import org.apache.poi.hssf.record.RecordInputStream;
import org.apache.poi.hssf.record.SelectionRecord;
import org.apache.poi.util.LittleEndianByteArrayOutputStream;
@@ -89,7 +90,7 @@ public class CellRangeAddress extends Ce
public String formatAsString(String sheetName, boolean useAbsoluteAddress) {
StringBuffer sb = new StringBuffer();
if (sheetName != null) {
- sb.append(sheetName);
+ sb.append(SheetNameFormatter.format(sheetName));
sb.append("!");
}
CellReference cellRefFrom = new CellReference(getFirstRow(), getFirstColumn(),
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org