[GitHub] [hive] pgaref commented on a change in pull request #2310: HIVE-25152: Remove Superfluous Logging Code

[GitBox <gi...@apache.org>]

pgaref commented on a change in pull request #2310:
URL: https://github.com/apache/hive/pull/2310#discussion_r637382683



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java
##########
@@ -267,9 +267,7 @@ protected void initializeOp(Configuration hconf) throws HiveException {
     reduceSkipTag = conf.getSkipTag();
     reduceTagByte = (byte) conf.getTag();
 
-    if (LOG.isInfoEnabled()) {
-      LOG.info("Using tag = " + (int) reduceTagByte);
-    }
+    LOG.info("Using tag = " + reduceTagByte);

Review comment:
       Using tag = {} 

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java
##########
@@ -382,9 +380,7 @@ protected void closeOp(boolean abort) throws HiveException {
     super.closeOp(abort);
     out = null;
     reducerHash = null;
-    if (LOG.isInfoEnabled()) {
-      LOG.info(toString() + ": records written - " + numRows);
-    }
+    LOG.info(this + ": records written - " + numRows);

Review comment:
       {} : records written - {}




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org