You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Ferdinand Soethe <fe...@apache.org> on 2005/11/25 07:39:02 UTC

Scales Skin added to head

It's done. After a little hickup with subclipse (never copy
directories in eclipse), I've just added the new 'scales'-skin.

For the moment it just offers the showWhenSelected feature for large
sites (see discussion in thread "Menu Overhead Problem (and
an offer to fix it)").

In a second commit I have added a demo of this feature in the samples
section of fresh site to show that

a) the type-attribute in site.xml-elements doesn't interfere with a
   normal skins like pelt.
b) adds the desired effect when you switch freshsite to scales.

Not sure what else is needed to publish the skin. Following the
instructions for publishing a new skin, I get an error because the
script is looking for a versioned skin dir name ('scales-0.8-dev.zip').

But since all the other skin dir names are still unchanged, I'm not
sure what to do. In my tests, scales works as it is.


--
Ferdinand Soethe


Re: Scales Skin added to head

Posted by Ross Gardler <rg...@apache.org>.
Ferdinand Soethe wrote:
> David Crossley wrote:
> 
> 
>>Perhaps i missed the discussion, why did this need
>>a separate new skin? Why not just do it in "pelt" skin? 
>>Less maintenance is better.
> 
> 
> Yeah. Better read the discussions.
> My reasons:
> 
> - I decided that it's easier to make it a new skin so people have a
>   choice. If enough people like it, I'm happy to add it to pelt.

For this feature there was no need for this, but...

> - I'm working on other additional features and design changes that
>   might be even more controversial.

this one makes it sound like you are making your life easier in the 
future, smart move ;-)

Ross


Re: Scales Skin added to head

Posted by Ferdinand Soethe <fe...@apache.org>.
David Crossley wrote:

> Perhaps i missed the discussion, why did this need
> a separate new skin? Why not just do it in "pelt" skin? 
> Less maintenance is better.

Yeah. Better read the discussions.
My reasons:

- I decided that it's easier to make it a new skin so people have a
  choice. If enough people like it, I'm happy to add it to pelt.
  
- I'm working on other additional features and design changes that
  might be even more controversial.

--
Ferdinand Soethe


Re: Scales Skin added to head

Posted by David Crossley <cr...@apache.org>.
Ferdinand Soethe wrote:
> It's done. After a little hickup with subclipse (never copy
> directories in eclipse), I've just added the new 'scales'-skin.
> 
> For the moment it just offers the showWhenSelected feature for large
> sites (see discussion in thread "Menu Overhead Problem (and
> an offer to fix it)").
> 
> In a second commit I have added a demo of this feature in the samples
> section of fresh site to show that
> 
> a) the type-attribute in site.xml-elements doesn't interfere with a
>    normal skins like pelt.
> b) adds the desired effect when you switch freshsite to scales.

Tried it, works nicely. Congratulations.

Perhaps i missed the discussion, why did this need
a separate new skin? Why not just do it in "pelt" skin? 
Less maintenance is better.

-David