You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/12 03:38:25 UTC
[GitHub] [shardingsphere] flycoolman opened a new pull request #7416: 7307
flycoolman opened a new pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416
Fixes #7307 .
Changes proposed in this pull request:
- Rename 'master' to 'primary'
- Rename 'Master' to 'Primary'
- Rename 'slave' to 'replica'
- Rename 'Slave' to 'Replica'
- Rename 'ms' to 'pr' if the 'ms' is the abbreviation of 'masterslave'
- Rename 'ds_m' to 'ds_p'
- Rename 'ds_ms' to 'ds_pr'
- Rename other combinations of 'master' and 'slave', such as 'master-slave', 'MasterSlave', 'MASTER', 'SLAVE', etc.
Hi @terrymanu @tristaZero ,
Please review the changes and let me know any further changes. This fix does not include the folder of 'examples'.
I have all the tests pass locally. I would like to keep this fix as small as possible, as long as all the tests can pass.
Thanks for your patience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] flycoolman commented on pull request #7416: Rename MasterSlave module to ReadWriteSplit
Posted by GitBox <gi...@apache.org>.
flycoolman commented on pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#issuecomment-691405934
> Please change the title of pr to make sense
Changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #7416: 7307
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#issuecomment-691400177
Please change the title of pr to make sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] flycoolman commented on a change in pull request #7416: 7307
Posted by GitBox <gi...@apache.org>.
flycoolman commented on a change in pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#discussion_r487364135
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
Got it!
If there are other places you can imagine to use other names, not just plain translate from master-slave to primary-replica, please let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7416: 7307
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#discussion_r487363294
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
The module name should be read-write-split
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
The rule name should be ReadWriteSplitRuleConfiguration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] flycoolman commented on a change in pull request #7416: 7307
Posted by GitBox <gi...@apache.org>.
flycoolman commented on a change in pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#discussion_r487364171
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
Will change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7416: 7307
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#discussion_r487363294
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
The module name should be read-write-split
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
The rule name should be ReadWriteSplitRuleConfiguration
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
The module name should be read-write-split
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
The rule name should be ReadWriteSplitRuleConfiguration
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
The module name should be read-write-split
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
The rule name should be ReadWriteSplitRuleConfiguration
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
The module name should be read-write-split
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
The rule name should be ReadWriteSplitRuleConfiguration
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
The module name should be read-write-split
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
The rule name should be ReadWriteSplitRuleConfiguration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on pull request #7416: Rename MasterSlave module to ReadWriteSplit
Posted by GitBox <gi...@apache.org>.
kimmking commented on pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#issuecomment-691531427
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on pull request #7416: Rename MasterSlave module to ReadWriteSplit
Posted by GitBox <gi...@apache.org>.
kimmking commented on pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#issuecomment-691531427
Hi, @flycoolman
You should resolve the conficts first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] flycoolman commented on a change in pull request #7416: Rename MasterSlave module to ReadWriteSplit
Posted by GitBox <gi...@apache.org>.
flycoolman commented on a change in pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#discussion_r487640251
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
> Hi, @flycoolman
> You should resolve the conficts first.
@kimmking Thanks for the suggestion.
That will be my next action once the final decision about the module name is made.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #7416: 7307
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#issuecomment-691400177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] flycoolman commented on a change in pull request #7416: 7307
Posted by GitBox <gi...@apache.org>.
flycoolman commented on a change in pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#discussion_r487364135
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
Got it!
If there are other places you can imagine to use other names, not just plain translate from master-slave to primary-replica, please let me know.
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
Will change
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
Got it!
If there are other places you can imagine to use other names, not just plain translate from master-slave to primary-replica, please let me know.
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
Will change
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
Got it!
If there are other places you can imagine to use other names, not just plain translate from master-slave to primary-replica, please let me know.
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
Will change
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
Got it!
If there are other places you can imagine to use other names, not just plain translate from master-slave to primary-replica, please let me know.
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
Will change
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
Got it!
If there are other places you can imagine to use other names, not just plain translate from master-slave to primary-replica, please let me know.
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
Will change
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
Got it!
If there are other places you can imagine to use other names, not just plain translate from master-slave to primary-replica, please let me know.
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
Will change
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
Got it!
If there are other places you can imagine to use other names, not just plain translate from master-slave to primary-replica, please let me know.
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
Will change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #7416: 7307
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#issuecomment-691400516
I notice you commit `404` times which is unbelievable.
Can you reference the Contributor Guide(https://shardingsphere.apache.org/community/en/contribute/contributor/) to standardize your commit operation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #7416: 7307
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#issuecomment-691400177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] flycoolman commented on pull request #7416: Rename MasterSlave module to ReadWriteSplit
Posted by GitBox <gi...@apache.org>.
flycoolman commented on pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#issuecomment-691405803
> I notice you commit `404` times which is unbelievable.
> Can you reference the Contributor Guide(https://shardingsphere.apache.org/community/en/contribute/contributor/) to standardize your commit operation?
Sorry about this. I definitely can squash the commits.
Just FYI:
Basically the commits were based on files that were changed accordingly, as other modules have dependency on the ReadWriteSplit module. Hopefully I did not do it out of scope.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] flycoolman commented on pull request #7416: Rename MasterSlave module to ReadWriteSplit
Posted by GitBox <gi...@apache.org>.
flycoolman commented on pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#issuecomment-693397191
Close this and open a new one when the changes are done.
Current status:
Still pending on the final decision about this change which will be made.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #7416: Rename MasterSlave module to ReadWriteSplit
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#issuecomment-693235086
Maybe we need to close this pr because of the commit log is error.
It is better to open a new pr to do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] flycoolman commented on pull request #7416: Rename MasterSlave module to ReadWriteSplit
Posted by GitBox <gi...@apache.org>.
flycoolman commented on pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#issuecomment-691798353
> Hi, @flycoolman
> You should resolve the conficts first.
@kimmking Thanks for the suggestion.
That will be my next action once the final decision about the module name is made.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] flycoolman closed pull request #7416: Rename MasterSlave module to ReadWriteSplit
Posted by GitBox <gi...@apache.org>.
flycoolman closed pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #7416: 7307
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#issuecomment-691400177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7416: 7307
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#discussion_r487363294
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
The module name should be read-write-split
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
The rule name should be ReadWriteSplitRuleConfiguration
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
The module name should be read-write-split
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
The rule name should be ReadWriteSplitRuleConfiguration
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
The module name should be read-write-split
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
The rule name should be ReadWriteSplitRuleConfiguration
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
The module name should be read-write-split
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
The rule name should be ReadWriteSplitRuleConfiguration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on pull request #7416: Rename MasterSlave module to ReadWriteSplit
Posted by GitBox <gi...@apache.org>.
kimmking commented on pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#issuecomment-691531427
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] flycoolman commented on a change in pull request #7416: 7307
Posted by GitBox <gi...@apache.org>.
flycoolman commented on a change in pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#discussion_r487364135
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
Got it!
If there are other places you can imagine to use other names, not just plain translate from master-slave to primary-replica, please let me know.
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
Will change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] flycoolman commented on pull request #7416: Rename MasterSlave module to ReadWriteSplit
Posted by GitBox <gi...@apache.org>.
flycoolman commented on pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#issuecomment-691405803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] flycoolman commented on a change in pull request #7416: 7307
Posted by GitBox <gi...@apache.org>.
flycoolman commented on a change in pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#discussion_r487364135
##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
<modules>
<module>shardingsphere-sharding</module>
<module>shardingsphere-replica</module>
- <module>shardingsphere-master-slave</module>
+ <module>shardingsphere-primary-replica</module>
Review comment:
Got it!
If there are other places you can imagine to use other names, not just plain translate from master-slave to primary-replica, please let me know.
##########
File path: shardingsphere-features/shardingsphere-primary-replica/shardingsphere-primary-replica-api/src/main/java/org/apache/shardingsphere/primaryreplica/api/config/PrimaryReplicaRuleConfiguration.java
##########
@@ -15,25 +15,25 @@
* limitations under the License.
*/
-package org.apache.shardingsphere.masterslave.api.config;
+package org.apache.shardingsphere.primaryreplica.api.config;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.apache.shardingsphere.infra.config.RuleConfiguration;
import org.apache.shardingsphere.infra.config.algorithm.ShardingSphereAlgorithmConfiguration;
-import org.apache.shardingsphere.masterslave.api.config.rule.MasterSlaveDataSourceRuleConfiguration;
+import org.apache.shardingsphere.primaryreplica.api.config.rule.PrimaryReplicaDataSourceRuleConfiguration;
import java.util.Collection;
import java.util.Map;
/**
- * Master-slave rule configuration.
+ * Primary-replica rule configuration.
*/
@RequiredArgsConstructor
@Getter
-public final class MasterSlaveRuleConfiguration implements RuleConfiguration {
+public final class PrimaryReplicaRuleConfiguration implements RuleConfiguration {
Review comment:
Will change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org