[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1791: [CELEBORN-874] Enrich Fetch log

["waitinfuture (via GitHub)" <gi...@apache.org>]

waitinfuture commented on code in PR #1791:
URL: https://github.com/apache/incubator-celeborn/pull/1791#discussion_r1284603574


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/FetchHandler.scala:
##########
@@ -243,6 +246,16 @@ class FetchHandler(val conf: CelebornConf, val transportConf: TransportConf)
       client.getChannel.writeAndFlush(new ChunkFetchSuccess(req.streamChunkSlice, buf))
         .addListener(new GenericFutureListener[Future[_ >: Void]] {
           override def operationComplete(future: Future[_ >: Void]): Unit = {
+            if (log.isDebugEnabled) {
+              if (future.isSuccess()) {
+                logInfo(
+                  s"Sending ChunkFetchSuccess operation succeeded, chunk ${req.streamChunkSlice}")
+              } else {
+                logError(

Review Comment:
   I think we should always print the error log, even it debug is disabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org