[jira] [Closed] (OPENNLP-1039) PerceptronTrainer should call super.isValid() in its isValid()

["Koji Sekiguchi (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OPENNLP-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Sekiguchi closed OPENNLP-1039.
-----------------------------------

> PerceptronTrainer should call super.isValid() in its isValid()
> --------------------------------------------------------------
>
>                 Key: OPENNLP-1039
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1039
>             Project: OpenNLP
>          Issue Type: Bug
>            Reporter: Koji Sekiguchi
>            Assignee: Koji Sekiguchi
>            Priority: Trivial
>             Fix For: 1.8.0
>
>
> The current implementation of PerceptronTrainer#isValid() is:
> {code}
>   public boolean isValid() {
>     String algorithmName = getAlgorithm();
>     return !(algorithmName != null && !(PERCEPTRON_VALUE.equals(algorithmName)));
>   }
> {code}
> but it should call super.isValid() to check iterations and cutoff parameters because PerceptronTrainer uses them.
> And if possible, I'd like to rewrite the last line (return statement) because I needed a few minutes to understand it as it has three exclamation points in one line. :)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)