You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/29 07:00:37 UTC

[GitHub] [spark] wankunde opened a new pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

wankunde opened a new pull request #28944:
URL: https://github.com/apache/spark/pull/28944


   ### What changes were proposed in this pull request?
   
   When INSERT OVERWRITE a partitioned data source table, spark will verify input and output paths by default. Set to false to skip the verify in some cases.  (eg. INSERT OVERWRITE t partition(dt=a) SELECT * FROM t WHERE dt=b)
   
   ### Why are the changes needed?
   
   Without this parameter , SQL like ` INSERT OVERWRITE t partition(dt=a) SELECT * FROM t WHERE dt=b` will throw `AnalysisException` exception.
   
   ```
   Exception in thread "main" org.apache.spark.sql.AnalysisException: Cannot overwrite a path that is also being read from.;
   	at org.apache.spark.sql.execution.command.DDLUtils$.verifyNotReadPath(ddl.scala:940)
   	at org.apache.spark.sql.execution.datasources.DataSourceAnalysis$$anonfun$apply$1.applyOrElse(DataSourceStrategy.scala:226)
   	at org.apache.spark.sql.execution.datasources.DataSourceAnalysis$$anonfun$apply$1.applyOrElse(DataSourceStrategy.scala:146)
   ```
    
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   
   Add new test case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-652031742


   **[Test build #124654 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124654/testReport)** for PR 28944 at commit [`a031795`](https://github.com/apache/spark/commit/a031795579642ddc6d87b2c40d85bd86b483e1de).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-663877485






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-664162556


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-663852441






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-663852288


   **[Test build #126547 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126547/testReport)** for PR 28944 at commit [`856a111`](https://github.com/apache/spark/commit/856a111911660014129302691af37d6a3efc094f).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-671120124


   Retest this please.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] github-actions[bot] closed pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #28944:
URL: https://github.com/apache/spark/pull/28944


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-664091733






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-671120528


   **[Test build #127246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127246/testReport)** for PR 28944 at commit [`4b8927a`](https://github.com/apache/spark/commit/4b8927ac2ecc7304885821e9cfe6b262c5e02781).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-650980386


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] holdenk commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-663524709


   A good first step in getting reviewers is normally getting the unit tests passing. This way it shows up on the review dashboard in a better state for review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-664161111


   **[Test build #126602 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126602/testReport)** for PR 28944 at commit [`4b8927a`](https://github.com/apache/spark/commit/4b8927ac2ecc7304885821e9cfe6b262c5e02781).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-663877278


   **[Test build #126547 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126547/testReport)** for PR 28944 at commit [`856a111`](https://github.com/apache/spark/commit/856a111911660014129302691af37d6a3efc094f).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] holdenk commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-651413175


   Jenkins ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-650986142


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wankunde commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
wankunde commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-671190152


   Hi, @viirya what do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-671120528


   **[Test build #127246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127246/testReport)** for PR 28944 at commit [`4b8927a`](https://github.com/apache/spark/commit/4b8927ac2ecc7304885821e9cfe6b262c5e02781).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wankunde commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
wankunde commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-654255062


   @holdenk Could you help review this PR ?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wankunde commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
wankunde commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-664185800


   Hi, @srowen @dongjoon-hyun All checks passed and all UT passed, but SparkQA report an exception:  `This patch fails due to an unknown error code, -9.` ,  Can you help me?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-663852288


   **[Test build #126547 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126547/testReport)** for PR 28944 at commit [`856a111`](https://github.com/apache/spark/commit/856a111911660014129302691af37d6a3efc094f).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-664091420


   **[Test build #126602 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126602/testReport)** for PR 28944 at commit [`4b8927a`](https://github.com/apache/spark/commit/4b8927ac2ecc7304885821e9cfe6b262c5e02781).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-652033447


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124654/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-663877485






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wankunde commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
wankunde commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-664749624






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-652033438






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-663852441






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-664162562


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126602/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] viirya commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-664759851


   I see. I meant, use dynamic partition overwrite can be workaround of this limit. Besides, if you already know the partition you are going to insert doesn't exist, why use insert overwrite?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-671174527






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-671120715






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-671173520


   **[Test build #127246 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127246/testReport)** for PR 28944 at commit [`4b8927a`](https://github.com/apache/spark/commit/4b8927ac2ecc7304885821e9cfe6b262c5e02781).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] github-actions[bot] commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-730047323


   We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wankunde commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
wankunde commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-664090347


   rebase PR, and test again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-651899675


   **[Test build #124654 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124654/testReport)** for PR 28944 at commit [`a031795`](https://github.com/apache/spark/commit/a031795579642ddc6d87b2c40d85bd86b483e1de).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-652033438


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-664003057


   cc @viirya .
   This sounds like an extension on top of SPARK-30112.
   ```
   [SPARK-30112][SQL] Allow insert overwrite same table if using dynamic partition overwrite
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-664162556






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-663992692


   It's probably a spurious unrelated error and may not occur again on a next test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wankunde commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
wankunde commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-663353487


   @dongjoon-hyun @srowen @Ngone51 
   
   Could someone help me review this PR? thanks.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-663542685


   Why do you need to skip this check - is it safe to write what you're reading in some case?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-671174527






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-671120715






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-664091733






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-650980386


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-664091420


   **[Test build #126602 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126602/testReport)** for PR 28944 at commit [`4b8927a`](https://github.com/apache/spark/commit/4b8927ac2ecc7304885821e9cfe6b262c5e02781).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wankunde commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
wankunde commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-663948721


   Hi, @holdenk @srowen I have rebase this PR, and passes all tests. 
   
   I don't know why sparkr throw the following exception in checking. Can you help me?
   
   `(converted from warning) Use 'read_ipc_stream' or 'read_feather' instead.`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28944: [SPARK-32128][SQL]import SQLConf.PARTITION_OVERWRITE_VERIFY_PATH config

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28944:
URL: https://github.com/apache/spark/pull/28944#issuecomment-650986142


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org