You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Timothy St. Clair" <ts...@redhat.com> on 2014/08/11 18:45:40 UTC

Review Request 24563: MESOS-1693: enable build against non-x86 arch

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/
-----------------------------------------------------------

Review request for mesos, Adam B and Vinod Kone.


Bugs: MESOS-1693
    https://issues.apache.org/jira/browse/MESOS-1693


Repository: mesos-git


Description
-------

Enable building against non-x86 arch, namely arm builders on Fedora.


Diffs
-----

  3rdparty/libprocess/include/process/internal.hpp 9f478ec 
  3rdparty/libprocess/src/process.cpp 14cf317 
  configure.ac 8fb0a3a 

Diff: https://reviews.apache.org/r/24563/diff/


Testing
-------

make check


Thanks,

Timothy St. Clair

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

Posted by "Timothy St. Clair" <ts...@redhat.com>.

> On Aug. 11, 2014, 4:57 p.m., Dominic Hamon wrote:
> > Have you tested this on ppc?
> 
> Timothy St. Clair wrote:
>     Tested no, but it should enable the build now, which was the goal at this point.
> 
> Vinod Kone wrote:
>     Please test this locally before updating upstream.

It's been tested on existing platforms, but I don't have resources to test ppc ... I just figure we should not inhibit their ability to build as I've been explicitly asked to enable.  


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50186
-----------------------------------------------------------


On Aug. 11, 2014, 4:45 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 4:45 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-1693
>     https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp 14cf317 
>   configure.ac 8fb0a3a 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

Posted by "Timothy St. Clair" <ts...@redhat.com>.

> On Aug. 11, 2014, 4:57 p.m., Dominic Hamon wrote:
> > Have you tested this on ppc?

Tested no, but it should enable the build now, which was the goal at this point. 


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50186
-----------------------------------------------------------


On Aug. 11, 2014, 4:45 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 4:45 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-1693
>     https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp 14cf317 
>   configure.ac 8fb0a3a 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

Posted by Vinod Kone <vi...@gmail.com>.

> On Aug. 11, 2014, 4:57 p.m., Dominic Hamon wrote:
> > Have you tested this on ppc?
> 
> Timothy St. Clair wrote:
>     Tested no, but it should enable the build now, which was the goal at this point.

Please test this locally before updating upstream.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50186
-----------------------------------------------------------


On Aug. 11, 2014, 4:45 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 4:45 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-1693
>     https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp 14cf317 
>   configure.ac 8fb0a3a 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50186
-----------------------------------------------------------


Have you tested this on ppc?

- Dominic Hamon


On Aug. 11, 2014, 9:45 a.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 9:45 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-1693
>     https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp 14cf317 
>   configure.ac 8fb0a3a 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/
-----------------------------------------------------------

(Updated Aug. 14, 2014, 6:38 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.


Changes
-------

remove the nop s


Bugs: MESOS-1693
    https://issues.apache.org/jira/browse/MESOS-1693


Repository: mesos-git


Description
-------

Enable building against non-x86 arch, namely arm builders on Fedora.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/internal.hpp 9f478ec 
  3rdparty/libprocess/src/process.cpp c2bee98 
  configure.ac 321f09d 

Diff: https://reviews.apache.org/r/24563/diff/


Testing
-------

make check


Thanks,

Timothy St. Clair

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50614
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/include/process/internal.hpp
<https://reviews.apache.org/r/24563/#comment88482>

    I would sugguest remove the "nop" here (this is a spin lock anyway and nop is not available on all other archs).
    
    #if defined(__i386__) || defined(__x86_64__)
      asm volatile ("pause")
    #endif



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/24563/#comment88483>

    Ditto.


- Jie Yu


On Aug. 14, 2014, 6:16 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 6:16 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.
> 
> 
> Bugs: MESOS-1693
>     https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp c2bee98 
>   configure.ac 321f09d 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/
-----------------------------------------------------------

(Updated Aug. 14, 2014, 6:16 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.


Changes
-------

update per review.


Bugs: MESOS-1693
    https://issues.apache.org/jira/browse/MESOS-1693


Repository: mesos-git


Description
-------

Enable building against non-x86 arch, namely arm builders on Fedora.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/internal.hpp 9f478ec 
  3rdparty/libprocess/src/process.cpp c2bee98 
  configure.ac 321f09d 

Diff: https://reviews.apache.org/r/24563/diff/


Testing
-------

make check


Thanks,

Timothy St. Clair

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

Posted by "Timothy St. Clair" <ts...@redhat.com>.

> On Aug. 14, 2014, 4:44 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/include/process/internal.hpp, line 18
> > <https://reviews.apache.org/r/24563/diff/1/?file=657649#file657649line18>
> >
> >     Do all the other arch have "nop" instruction?

That I'm aware of, yes.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50590
-----------------------------------------------------------


On Aug. 14, 2014, 6:38 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 6:38 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.
> 
> 
> Bugs: MESOS-1693
>     https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp c2bee98 
>   configure.ac 321f09d 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50590
-----------------------------------------------------------



3rdparty/libprocess/include/process/internal.hpp
<https://reviews.apache.org/r/24563/#comment88453>

    for #ifdef blocks, that's how we align:
    
    {
      while (!...) {
    #if defined(...) || defined(...)
        asm volatile ...
    #else
        ...
    #endif
      }
    }



3rdparty/libprocess/include/process/internal.hpp
<https://reviews.apache.org/r/24563/#comment88454>

    Do all the other arch have "nop" instruction?



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/24563/#comment88455>

    Ditto.


- Jie Yu


On Aug. 13, 2014, 7:30 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 7:30 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.
> 
> 
> Bugs: MESOS-1693
>     https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp 14cf317 
>   configure.ac 8fb0a3a 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/
-----------------------------------------------------------

(Updated Aug. 13, 2014, 7:30 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu.


Changes
-------

Adding Jie as this is a quick review I would like to get in for 0.20


Bugs: MESOS-1693
    https://issues.apache.org/jira/browse/MESOS-1693


Repository: mesos-git


Description
-------

Enable building against non-x86 arch, namely arm builders on Fedora.


Diffs
-----

  3rdparty/libprocess/include/process/internal.hpp 9f478ec 
  3rdparty/libprocess/src/process.cpp 14cf317 
  configure.ac 8fb0a3a 

Diff: https://reviews.apache.org/r/24563/diff/


Testing
-------

make check


Thanks,

Timothy St. Clair

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50368
-----------------------------------------------------------


Patch looks great!

Reviews applied: [24563]

All tests passed.

- Mesos ReviewBot


On Aug. 11, 2014, 8:32 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 8:32 p.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1693
>     https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp 14cf317 
>   configure.ac 8fb0a3a 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/
-----------------------------------------------------------

(Updated Aug. 11, 2014, 8:32 p.m.)


Review request for mesos, Adam B and Benjamin Hindman.


Changes
-------

@benh: can you take a look at this?


Bugs: MESOS-1693
    https://issues.apache.org/jira/browse/MESOS-1693


Repository: mesos-git


Description
-------

Enable building against non-x86 arch, namely arm builders on Fedora.


Diffs
-----

  3rdparty/libprocess/include/process/internal.hpp 9f478ec 
  3rdparty/libprocess/src/process.cpp 14cf317 
  configure.ac 8fb0a3a 

Diff: https://reviews.apache.org/r/24563/diff/


Testing
-------

make check


Thanks,

Timothy St. Clair