You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/02/10 12:31:14 UTC
[GitHub] [hive] deniskuzZ opened a new pull request #3015: HIVE-25934: Non blocking RENAME PARTITION implementation
deniskuzZ opened a new pull request #3015:
URL: https://github.com/apache/hive/pull/3015
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #3015: HIVE-25934: Non blocking RENAME PARTITION implementation
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #3015:
URL: https://github.com/apache/hive/pull/3015#discussion_r804488349
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java
##########
@@ -448,6 +448,20 @@ public boolean renameDir(Path sourcePath, Path destPath, boolean needCmRecycle)
return false;
}
+ public boolean copyDir(Path sourcePath, Path destPath, boolean needCmRecycle) throws MetaException {
+ try {
+ if (needCmRecycle) {
+ cm.recycle(sourcePath, RecycleType.COPY, true);
+ }
+ FileSystem srcFs = getFs(sourcePath);
+ FileSystem destFs = getFs(destPath);
+ return FileUtils.copy(srcFs, sourcePath, destFs, destPath, false, false, conf);
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #3015: HIVE-25934: Non blocking RENAME PARTITION implementation
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #3015:
URL: https://github.com/apache/hive/pull/3015#issuecomment-1085623423
Looks good.
I left one minor comment in the code, and also, could you please look through the code and check if somewhere additional info or debug level logging could help later?
Thanks,
Peter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on pull request #3015: HIVE-25934: Non blocking RENAME PARTITION implementation
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on pull request #3015:
URL: https://github.com/apache/hive/pull/3015#issuecomment-1085939784
added extra logging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #3015: HIVE-25934: Non blocking RENAME PARTITION implementation
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #3015:
URL: https://github.com/apache/hive/pull/3015#discussion_r840825262
##########
File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -2109,7 +2109,8 @@ struct RenamePartitionRequest {
3: required string tableName,
4: required list<string> partVals,
5: required Partition newPart,
- 6: optional string validWriteIdList
+ 6: optional string validWriteIdList,
+ 7: optional EnvironmentContext environmentContext
Review comment:
By my understanding - EnvironmentContext was the first solution for extending the interface with new fields without adding new methods every time. This solution evolved to the `...Request` objects later.
Since we have a `RenamePartitionRequest` already, it might be better to use that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #3015: HIVE-25934: Non blocking RENAME PARTITION implementation
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #3015:
URL: https://github.com/apache/hive/pull/3015#discussion_r840414832
##########
File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -2109,7 +2109,8 @@ struct RenamePartitionRequest {
3: required string tableName,
4: required list<string> partVals,
5: required Partition newPart,
- 6: optional string validWriteIdList
+ 6: optional string validWriteIdList,
+ 7: optional EnvironmentContext environmentContext
Review comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] rbalamohan commented on a change in pull request #3015: HIVE-25934: Non blocking RENAME PARTITION implementation
Posted by GitBox <gi...@apache.org>.
rbalamohan commented on a change in pull request #3015:
URL: https://github.com/apache/hive/pull/3015#discussion_r803827123
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java
##########
@@ -448,6 +448,20 @@ public boolean renameDir(Path sourcePath, Path destPath, boolean needCmRecycle)
return false;
}
+ public boolean copyDir(Path sourcePath, Path destPath, boolean needCmRecycle) throws MetaException {
+ try {
+ if (needCmRecycle) {
+ cm.recycle(sourcePath, RecycleType.COPY, true);
+ }
+ FileSystem srcFs = getFs(sourcePath);
+ FileSystem destFs = getFs(destPath);
+ return FileUtils.copy(srcFs, sourcePath, destFs, destPath, false, false, conf);
Review comment:
minor comment. This can turn out to be expensive depending on size of the directory, size and number of files. May be good to add a TODO for later ref/fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #3015: HIVE-25934: Non blocking RENAME PARTITION implementation
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #3015:
URL: https://github.com/apache/hive/pull/3015#discussion_r840617562
##########
File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -2109,7 +2109,8 @@ struct RenamePartitionRequest {
3: required string tableName,
4: required list<string> partVals,
5: required Partition newPart,
- 6: optional string validWriteIdList
+ 6: optional string validWriteIdList,
+ 7: optional EnvironmentContext environmentContext
Review comment:
checked the code: almost everywhere environmentContext is used to propagate extra params, drop table/partition follows the same approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on pull request #3015: HIVE-25934: Non blocking RENAME PARTITION implementation
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on pull request #3015:
URL: https://github.com/apache/hive/pull/3015#issuecomment-1085688946
> Looks good. I left one minor comment in the code, and also, could you please look through the code and check if somewhere additional info or debug level logging could help later?
>
> Thanks, Peter
Thanks @pvary for the review! I'll take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #3015: HIVE-25934: Non blocking RENAME PARTITION implementation
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #3015:
URL: https://github.com/apache/hive/pull/3015#discussion_r840365739
##########
File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -2109,7 +2109,8 @@ struct RenamePartitionRequest {
3: required string tableName,
4: required list<string> partVals,
5: required Partition newPart,
- 6: optional string validWriteIdList
+ 6: optional string validWriteIdList,
+ 7: optional EnvironmentContext environmentContext
Review comment:
Would it be better to add the flag as a parameter instead hiding in the environmentContext?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #3015: HIVE-25934: Non blocking RENAME PARTITION implementation
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #3015:
URL: https://github.com/apache/hive/pull/3015#discussion_r840366634
##########
File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -2109,7 +2109,8 @@ struct RenamePartitionRequest {
3: required string tableName,
4: required list<string> partVals,
5: required Partition newPart,
- 6: optional string validWriteIdList
+ 6: optional string validWriteIdList,
+ 7: optional EnvironmentContext environmentContext
Review comment:
Maybe also add the `txnId` too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org