[GitHub] [pulsar] sakurafly123 commented on a change in pull request #9910: [Pulsar-sql]Using pulsar SQL query messages will appear `NoSuchLedger…

[GitBox <gi...@apache.org>]

sakurafly123 commented on a change in pull request #9910:
URL: https://github.com/apache/pulsar/pull/9910#discussion_r613799296



##########
File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarConnectorCache.java
##########
@@ -112,7 +112,7 @@ private static ManagedLedgerFactory initManagedLedgerFactory(PulsarConnectorConf
                 pulsarConnectorConfig.getManagedLedgerNumWorkerThreads());
         managedLedgerFactoryConfig.setNumManagedLedgerSchedulerThreads(
                 pulsarConnectorConfig.getManagedLedgerNumSchedulerThreads());
-        return new ManagedLedgerFactoryImpl(bkClientConfiguration, managedLedgerFactoryConfig);
+        return new ManagedLedgerFactoryImpl(bkClientConfiguration, pulsarConnectorConfig.getZookeeperUri(),managedLedgerFactoryConfig);

Review comment:
       > The `ClientConfiguration` bkClientConfiguration is used to generate the bookkeeper, the `MetadataServiceUri` is enough, we don't need to set the `ZkServers` and the method `setZkServers` is deprecated.
   
   today,i found it's neccessay to setZkServers .when broker's zk Path is diffrent from bookies's zk Path.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org