[GitHub] [nifi] bbende commented on a change in pull request #3515: NIFI-6348: Added Custom ORDER BY Column property to GenerateTableFetch

[GitBox <gi...@apache.org>]

bbende commented on a change in pull request #3515: NIFI-6348: Added Custom ORDER BY Column property to GenerateTableFetch
URL: https://github.com/apache/nifi/pull/3515#discussion_r290748279
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java
 ##########
 @@ -154,6 +154,18 @@
             .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
             .build();
 
+    static final PropertyDescriptor CUSTOM_ORDERBY_COLUMN = new PropertyDescriptor.Builder()
+            .name("gen-table-custom-orderby-column")
+            .displayName("Custom ORDER BY Column")
+            .description("The name of a column to be used for ordering the results if Max-Value Columns are not provided and partitioning is enabled. This property is ignored if either "
+                    + "Max-Value Columns is set or Partition Size > 0. NOTE: If neither Max-Value Columns nor Custom ORDER BY Column is set, and Partition Size > 0, then depending on the "
 
 Review comment:
   Testing this out, everything look good, one minor comment/question - I think the statement about being ignored if max-value column is set or partition size is > 0 may not be totally right? should it be when partition size is = 0 ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services