You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2026/01/12 02:35:25 UTC

[PR] MINOR: [C++] Remove outdated TODO about generic ChunkedArray validation [arrow]

HyukjinKwon opened a new pull request, #48823:
URL: https://github.com/apache/arrow/pull/48823

   ### Rationale for this change
   
   Removed a TODO from `replace_with_mask` implementation that asking why the replacements null count wasn't sufficient for a slice operation. When slicing an array, the null count from the original full array doesn't apply to the slice.
   
   The null count must be marked as `kUnknownNullCount` and computed lazily when needed.
   
   ### What changes are included in this PR?
   
   Replaced the TODO with some comments clarifying:
   - Why manual slicing is used (avoids extra allocation from `ArrayData::Slice()`)
   - Why `kUnknownNullCount` is necessary (original null count doesn't apply to slice)
   
   ### Are these changes tested?
   
   No, I did not test.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: [C++] Remove TODO asking why null count set unknown [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48823:
URL: https://github.com/apache/arrow/pull/48823#issuecomment-3753035784

   After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit d65eb946326626da05f4aab8cfe0c68cbe63a498.
   
   There weren't enough matching historic benchmark results to make a call on whether there were regressions.
   
   The [full Conbench report](https://github.com/apache/arrow/runs/60437088932) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: [C++] Remove TODO asking why null count set unknown [arrow]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #48823:
URL: https://github.com/apache/arrow/pull/48823#issuecomment-3766998684

   Thank you guys!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: [C++] Remove TODO asking why null count set unknown [arrow]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #48823:
URL: https://github.com/apache/arrow/pull/48823


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org