[I] create-from-project + -Darchetype.preserveCData + multi-module + dependency is broken [maven-archetype]

["lalmeras (via GitHub)" <gi...@apache.org>]

lalmeras opened a new issue, #983:
URL: https://github.com/apache/maven-archetype/issues/983

   ### Affected version
   
   3.4.1
   
   ### Bug description
   
   When a multi-module project is used with create-from-project with preserveCData, dependencies between modules are broken.
   
   For the following hierarchy :
   * A
     * B
     * C -> B
   
   The built archetype replace B dependency in C module with a A dependency.
   
   From my investigation, bug originates from FilesetArchetypeCreator#createModulePoms, when artifactId/parentArtifactId properties are saved then restored while processing modules. parentArtifactId is restored with the currently processed artifactId instead of previous parentArtifactId (i.e. when B is processed, parentArtifactId is restored to B value instead of A).
   
   The bug triggers only when preserveCData is used, surely because pom model is used instead of parentArtifactId when preserveCData is false.
   
   I prepare a PR with an integration test and a fix proposal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] create-from-project + -Darchetype.preserveCData + multi-module + dependency is broken [maven-archetype]

["lalmeras (via GitHub)" <gi...@apache.org>]

lalmeras commented on issue #983:
URL: https://github.com/apache/maven-archetype/issues/983#issuecomment-3811192570

   Here is the PR : #984


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org