Re: [PR] Executors/Threads: Enforce reasonable rules [solr]

["dsmiley (via GitHub)" <gi...@apache.org>]

dsmiley commented on code in PR #4675:
URL: https://github.com/apache/solr/pull/4675#discussion_r3707699714


##########
solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java:
##########
@@ -245,36 +259,104 @@ public static ExecutorService newMDCAwareCachedThreadPool(String name) {
    * Create a new pool of threads, with no limit for the number of threads. The pool has no task
    * queue. Each submitted task is executed immediately, either by reusing an existing thread if one
    * is available, or by starting a new thread. Unused threads will be closed after 60 seconds.
+   *
+   * <p>Thread count tracks how many tasks run concurrently, but nothing bounds it: a burst of
+   * simultaneous tasks starts a thread apiece. Only use this where something upstream already
+   * limits how many tasks can be in flight.
    */
   public static ExecutorService newMDCAwareCachedThreadPool(ThreadFactory threadFactory) {

Review Comment:
   Yes; I'll do that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org