You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/04 10:18:20 UTC

[GitHub] juliusshufan opened a new pull request #9305: Fixing two symbol files for CNN

juliusshufan opened a new pull request #9305: Fixing two symbol files for CNN
URL: https://github.com/apache/incubator-mxnet/pull/9305
 
 
   ## Description ##
   This PR is trying to fix runtime errors when running benchmark_score.py on CPU machine.
   
   
   ### Changes ###
   Under example/image-classification/symbols:
   1. vgg.py, original implementation can't run preperly under Python3, as "has_key" method not supported by Python3;
   2. google.py, on CPU platform, the input to the last layer (7x7 avg pooling is 6x6, and therefore a runtime error will be triggered, I avoid this issue by add a (1,1) pad with the avg pooling.
   
   ## Checklist ##
   ### Essentials ###
   - [ ] Passed code style checking (`make lint`)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services