You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/07 18:33:00 UTC
[jira] [Commented] (ARTEMIS-1544) AMQP: Use proper typing when
accessing ApplicationProperties Map values
[ https://issues.apache.org/jira/browse/ARTEMIS-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282283#comment-16282283 ]
ASF GitHub Bot commented on ARTEMIS-1544:
-----------------------------------------
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1693
ARTEMIS-1544 Use the proper types when accessing ApplicationProperties
Use Map<String, Object> to access the ApplicationProperties section
which is the spec defined type for that section. This will prevent
breakage should proton-j be updated to reflect that in the definition of
that class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1544
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1693.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1693
----
commit 4c0466642105de0828a2d1d31f0d3c3c1f4697df
Author: Timothy Bish <ta...@gmail.com>
Date: 2017-12-07T18:30:53Z
ARTEMIS-1544 Use the proper types when accessing ApplicationProperties
Use Map<String, Object> to access the ApplicationProperties section
which is the spec defined type for that section. This will prevent
breakage should proton-j be updated to reflect that in the definition of
that class.
----
> AMQP: Use proper typing when accessing ApplicationProperties Map values
> -----------------------------------------------------------------------
>
> Key: ARTEMIS-1544
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1544
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.4.0
> Reporter: Timothy Bish
> Assignee: Timothy Bish
> Priority: Trivial
> Fix For: 2.5.0
>
>
> When accessing the Map carried in a ApplicationProperties section the code should use the proper types when casting as the keys are restricted to String values but the code uses an Object cast. This could cause issues later should proton-j be updated with generic type specification on that API.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)