[GitHub] [fluo-muchos] arvindshmicrosoft edited a comment on pull request #356: Normalize hdfs-site.xml across HA and non-HA cases

[GitBox <gi...@apache.org>]

arvindshmicrosoft edited a comment on pull request #356:
URL: https://github.com/apache/fluo-muchos/pull/356#issuecomment-657977076


   > 1. Agreed, it should now be possible to just use the nameservice_id instead of the namenode[0]. I will push up an update.
   
   @keith-turner I realized an issue which will prevent changing hdfs_root to use the nameservice_id right away: Since Fluo 1.2.0 does not have the [recent fix](https://github.com/apache/fluo/commit/957eaed4fed01cf93304b645cfcd27a42c5fb9d3) to ensure hdfs-site.xml is loaded, switching hdfs_root to the nameservice will cause problems for running Fluo using Muchos. So here is what I propose:
   1. We merge this PR in as it is. There will be no breaking changes as a result of just this change.
   2. In a subsequent PR, I will add a task to check if Fluo 1.x is being run, and in that case, patch fluo-env.sh to the equivalent of [the other fluo-env.sh fix](https://github.com/apache/fluo/commit/957eaed4fed01cf93304b645cfcd27a42c5fb9d3)
   3. In a third PR after the above one merges, I will change hdfs_root to use the nameservice_id in all cases
   
   I believe this will be a clean and safe way to proceed. Please let me know if you foresee any issues. If you are good, I will merge this PR and create tracking issues for the 2 follow-ups as mentioned above.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org