You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2021/04/02 10:13:52 UTC
[tinkerpop] branch TINKERPOP-2245 updated (f8c91fc -> e442983)
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a change to branch TINKERPOP-2245
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git.
from f8c91fc Closing the alias needs to close the underlying client with it
add d93fddb TINKERPOP-2245 Changed logging for sessions
new e442983 TINKERPOP-2245 gremlinPool needs to be defaulted to a larger value
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.travis.yml | 2 +-
.../gremlin/server/handler/MultiRexster.java | 2 +-
.../tinkerpop/gremlin/server/op/session/Session.java | 8 ++++----
.../gremlin/server/GremlinDriverIntegrateTest.java | 5 +++++
.../server/GremlinServerSessionIntegrateTest.java | 19 +++++++++++--------
.../gremlin/server/GremlinSessionTxIntegrateTest.java | 5 +++--
6 files changed, 25 insertions(+), 16 deletions(-)
[tinkerpop] 01/01: TINKERPOP-2245 gremlinPool needs to be defaulted
to a larger value
Posted by sp...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch TINKERPOP-2245
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit e442983a5f9775c5e5278ba9fd224c26c5953252
Author: Stephen Mallette <st...@amazon.com>
AuthorDate: Fri Apr 2 06:07:34 2021 -0400
TINKERPOP-2245 gremlinPool needs to be defaulted to a larger value
For environments like travis which might only have two cores there is a chance for tests to fail/not finish as they introduce blocks in requests that need to exist for tests to pass. If there aren't enough threads in the pool the requests can't be serviced properly and they fail.
---
.travis.yml | 2 +-
.../apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java | 5 +++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index ff3a058..b8b02a7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -60,7 +60,7 @@ jobs:
name: "gremlin server"
- script:
- "mvn clean install -q -DskipTests -Dci"
- - "travis_wait 60 mvn verify -pl :gremlin-server -DskipTests -DskipIntegrationTests=false -DincludeNeo4j -DtestUnified=true"
+ - "mvn verify -pl :gremlin-server -DskipTests -DskipIntegrationTests=false -DincludeNeo4j -DtestUnified=true"
name: "gremlin server - unified"
- script:
- "mvn clean install -q -DskipTests -Dci"
diff --git a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
index 7e09c95..d09ca6b 100644
--- a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
+++ b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
@@ -155,6 +155,11 @@ public class GremlinDriverIntegrateTest extends AbstractGremlinServerIntegration
public Settings overrideSettings(final Settings settings) {
final String nameOfTest = name.getMethodName();
+ // need to initialize pool to something bigger than what Travis has for available cores
+ // as we often need at least 3 threads in the pool to let these tests pass. not sure what
+ // the top number is but 8 seems to do the trick
+ settings.gremlinPool = 8;
+
switch (nameOfTest) {
case "shouldAliasTraversalSourceVariables":
case "shouldAliasTraversalSourceVariablesInSession":