[GitHub] [hive] pvary commented on a change in pull request #2865: HIVE-25792: Multi Insert query fails on CBO path

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2865:
URL: https://github.com/apache/hive/pull/2865#discussion_r767580354



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/HookRunner.java
##########
@@ -121,19 +121,27 @@ void runBeforeCompileHook(String command) {
   }
 
   /**
-  * Dispatches {@link QueryLifeTimeHook#afterCompile(QueryLifeTimeHookContext, boolean)}.
-  *
-  * @param command the Hive command that is being run
-  * @param compileError true if there was an error while compiling the command, false otherwise
-  */
-  void runAfterCompilationHook(String command, boolean compileError) {
+   * Dispatches {@link QueryLifeTimeHook#afterCompile(QueryLifeTimeHookContext, boolean)}.
+   *
+   * @param driverContext the DriverContext used for generating the HookContext
+   * @param analyzerContext the SemanticAnalyzer context for this query
+   * @param compileException the exception if one was thrown during the compilation
+   */
+  void runAfterCompilationHook(DriverContext driverContext, Context analyzerContext, Throwable compileException) {

Review comment:
       This is the original code from `Executor`:
   ```
         hookContext = new PrivateHookContext(driverContext.getPlan(), driverContext.getQueryState(),
             context.getPathToCS(), SessionState.get().getUserName(), SessionState.get().getUserIpAddress(),
             InetAddress.getLocalHost().getHostAddress(), driverContext.getOperationId(),
             SessionState.get().getSessionId(), Thread.currentThread().getName(), SessionState.get().isHiveServerQuery(),
             SessionState.getPerfLogger(), driverContext.getQueryInfo(), context);
   ```
   
   This uses `context`, and `driverContext`. Any idea how to replace the usage?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org