You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/16 23:11:20 UTC
[GitHub] [incubator-superset] riahk commented on a change in pull request #10922: feat: update saved query backend routing + add savedquery list
riahk commented on a change in pull request #10922:
URL: https://github.com/apache/incubator-superset/pull/10922#discussion_r489802911
##########
File path: superset-frontend/src/views/CRUD/data/common.ts
##########
@@ -36,8 +36,8 @@ export const commonMenuData = {
{
name: 'Saved Queries',
label: t('Saved Queries'),
- url: '/sqllab/my_queries/',
- usesRouter: false,
+ url: '/savedqueryview/list/',
+ usesRouter: true,
Review comment:
Turns out it does not, I think I misunderstood how we were using the feature flags. In which case the new Databases view feature flag also got broken with my last routing update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org