You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Jonathan Chang (Created) (JIRA)" <ji...@apache.org> on 2012/01/12 20:21:39 UTC
[jira] [Created] (HIVE-2714) Lots of special characters are not
handled in LIKE
Lots of special characters are not handled in LIKE
--------------------------------------------------
Key: HIVE-2714
URL: https://issues.apache.org/jira/browse/HIVE-2714
Project: Hive
Issue Type: Bug
Reporter: Jonathan Chang
Assignee: Jonathan Chang
Currently LIKE converts the string to a regular expression. It tries to handle special characters but many are not correctly handled, e.g. +, ?, |, etc. That code should just use Pattern.quote.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2714) Lots of special characters are not
handled in LIKE
Posted by "Jonathan Chang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Chang updated HIVE-2714:
---------------------------------
Attachment: HIVE-2714.D1239.1.patch
> Lots of special characters are not handled in LIKE
> --------------------------------------------------
>
> Key: HIVE-2714
> URL: https://issues.apache.org/jira/browse/HIVE-2714
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: HIVE-2714.D1239.1.patch, HIVE-2714.D1239.1.patch
>
>
> Currently LIKE converts the string to a regular expression. It tries to handle special characters but many are not correctly handled, e.g. +, ?, |, etc. That code should just use Pattern.quote.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2714) Lots of special characters are not
handled in LIKE
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2714:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed. Thanks Jonathan.
> Lots of special characters are not handled in LIKE
> --------------------------------------------------
>
> Key: HIVE-2714
> URL: https://issues.apache.org/jira/browse/HIVE-2714
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: HIVE-2714.D1239.1.patch, HIVE-2714.D1239.1.patch
>
>
> Currently LIKE converts the string to a regular expression. It tries to handle special characters but many are not correctly handled, e.g. +, ?, |, etc. That code should just use Pattern.quote.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2714) Lots of special characters are not
handled in LIKE
Posted by "Jonathan Chang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Chang updated HIVE-2714:
---------------------------------
Status: Patch Available (was: Open)
> Lots of special characters are not handled in LIKE
> --------------------------------------------------
>
> Key: HIVE-2714
> URL: https://issues.apache.org/jira/browse/HIVE-2714
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: HIVE-2714.D1239.1.patch
>
>
> Currently LIKE converts the string to a regular expression. It tries to handle special characters but many are not correctly handled, e.g. +, ?, |, etc. That code should just use Pattern.quote.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2714) Lots of special characters are not
handled in LIKE
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227863#comment-13227863 ]
Phabricator commented on HIVE-2714:
-----------------------------------
kevinwilfong has accepted the revision "HIVE-2714 [jira] Lots of special characters are not handled in LIKE".
+1 Will commit if tests pass
REVISION DETAIL
https://reviews.facebook.net/D1239
BRANCH
like
> Lots of special characters are not handled in LIKE
> --------------------------------------------------
>
> Key: HIVE-2714
> URL: https://issues.apache.org/jira/browse/HIVE-2714
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: HIVE-2714.D1239.1.patch
>
>
> Currently LIKE converts the string to a regular expression. It tries to handle special characters but many are not correctly handled, e.g. +, ?, |, etc. That code should just use Pattern.quote.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2714) Lots of special characters are not
handled in LIKE
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2714:
-----------------------------------
Fix Version/s: 0.9.0
> Lots of special characters are not handled in LIKE
> --------------------------------------------------
>
> Key: HIVE-2714
> URL: https://issues.apache.org/jira/browse/HIVE-2714
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Fix For: 0.9.0
>
> Attachments: HIVE-2714.D1239.1.patch, HIVE-2714.D1239.1.patch
>
>
> Currently LIKE converts the string to a regular expression. It tries to handle special characters but many are not correctly handled, e.g. +, ?, |, etc. That code should just use Pattern.quote.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2714) Lots of special characters are not
handled in LIKE
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2714:
------------------------------
Attachment: HIVE-2714.D1239.1.patch
jonchang requested code review of "HIVE-2714 [jira] Lots of special characters are not handled in LIKE".
Reviewers: JIRA
HIVE-2714
Currently LIKE converts the string to a regular expression. It tries to handle special characters but many are not correctly handled, e.g. +, ?, |, etc. That code should just use Pattern.quote.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1239
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLike.java
ql/src/test/queries/clientpositive/udf_like.q
ql/src/test/results/clientpositive/udf_like.q.out
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2541/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Lots of special characters are not handled in LIKE
> --------------------------------------------------
>
> Key: HIVE-2714
> URL: https://issues.apache.org/jira/browse/HIVE-2714
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: HIVE-2714.D1239.1.patch
>
>
> Currently LIKE converts the string to a regular expression. It tries to handle special characters but many are not correctly handled, e.g. +, ?, |, etc. That code should just use Pattern.quote.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2714) Lots of special characters are not
handled in LIKE
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228188#comment-13228188 ]
Hudson commented on HIVE-2714:
------------------------------
Integrated in Hive-trunk-h0.21 #1307 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1307/])
HIVE-2714. Lots of special characters are not handled in LIKE. (jonchang via kevinwilfong) (Revision 1299948)
Result = FAILURE
kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299948
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLike.java
* /hive/trunk/ql/src/test/queries/clientpositive/udf_like.q
* /hive/trunk/ql/src/test/results/clientpositive/udf_like.q.out
> Lots of special characters are not handled in LIKE
> --------------------------------------------------
>
> Key: HIVE-2714
> URL: https://issues.apache.org/jira/browse/HIVE-2714
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: HIVE-2714.D1239.1.patch, HIVE-2714.D1239.1.patch
>
>
> Currently LIKE converts the string to a regular expression. It tries to handle special characters but many are not correctly handled, e.g. +, ?, |, etc. That code should just use Pattern.quote.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira