You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "shukitchan (via GitHub)" <gi...@apache.org> on 2024/04/29 23:28:14 UTC

[PR] Update XPACK.cc - initialize the table after allocation to avoid bad access [trafficserver]

shukitchan opened a new pull request, #11301:
URL: https://github.com/apache/trafficserver/pull/11301

   Let's determine if we need this after fixing #11287 and whether fuzzing complains on other code path


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update XPACK.cc - initialize the table after allocation to avoid bad access [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #11301:
URL: https://github.com/apache/trafficserver/pull/11301#issuecomment-2087087943

   > if you forget to initialize an entry before using it accidentally, it will be less harmful.
   
   Until the buffer is overwritten. An argument would be that we should zero-clear an entry when we remove it as well. That would make sense, but I'm not sure if it worth. I think letting the fuzzer find the errors, and/or having more unit tests is safer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update XPACK.cc - initialize the table after allocation to avoid bad access [trafficserver]

Posted by "shukitchan (via GitHub)" <gi...@apache.org>.
shukitchan commented on PR #11301:
URL: https://github.com/apache/trafficserver/pull/11301#issuecomment-2122910561

   Let's not worry about this for now till the fuzzer reports another problem related to this part. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update XPACK.cc - initialize the table after allocation to avoid bad access [trafficserver]

Posted by "shukitchan (via GitHub)" <gi...@apache.org>.
shukitchan commented on PR #11301:
URL: https://github.com/apache/trafficserver/pull/11301#issuecomment-2083929588

   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update XPACK.cc - initialize the table after allocation to avoid bad access [trafficserver]

Posted by "shukitchan (via GitHub)" <gi...@apache.org>.
shukitchan commented on PR #11301:
URL: https://github.com/apache/trafficserver/pull/11301#issuecomment-2086959629

   I think the actual benefit is that it is a precaution. if you forget to initialize an entry before using it accidentally, it will be less harmful. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update XPACK.cc - initialize the table after allocation to avoid bad access [trafficserver]

Posted by "shukitchan (via GitHub)" <gi...@apache.org>.
shukitchan closed pull request #11301: Update XPACK.cc - initialize the table after allocation to avoid bad access
URL: https://github.com/apache/trafficserver/pull/11301


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update XPACK.cc - initialize the table after allocation to avoid bad access [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #11301:
URL: https://github.com/apache/trafficserver/pull/11301#issuecomment-2086226262

   Let's say the fuzzer doesn't find anything at the moment. How do we know index numbers are checked appropriately at every place, after we make changes?
   
   Also, the zeros set by memset are only available until actual entries overwrite them.
   
   I still don't get the benefit of doing this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org