You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2020/08/30 20:46:54 UTC

[lucene-solr] branch reference_impl updated: @642 Try and settle down this leak, even though it's essentially a valid leak, we don't deal with it quite yet.

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/reference_impl by this push:
     new d8e9aa6  @642 Try and settle down this leak, even though it's essentially a valid leak, we don't deal with it quite yet.
d8e9aa6 is described below

commit d8e9aa67b9c16b6da188984a5b3710fe240280b3
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Sun Aug 30 15:46:37 2020 -0500

    @642 Try and settle down this leak, even though it's essentially a valid leak, we don't deal with it quite yet.
---
 .../solrj/src/test/org/apache/solr/client/solrj/SolrExceptionTest.java | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/solr/solrj/src/test/org/apache/solr/client/solrj/SolrExceptionTest.java b/solr/solrj/src/test/org/apache/solr/client/solrj/SolrExceptionTest.java
index c146d3b..ebab51b 100644
--- a/solr/solrj/src/test/org/apache/solr/client/solrj/SolrExceptionTest.java
+++ b/solr/solrj/src/test/org/apache/solr/client/solrj/SolrExceptionTest.java
@@ -18,6 +18,7 @@ package org.apache.solr.client.solrj;
 
 import static org.apache.solr.SolrTestCaseJ4.getHttpSolrClient;
 
+import com.carrotsearch.randomizedtesting.annotations.ThreadLeakLingering;
 import org.apache.http.impl.client.CloseableHttpClient;
 import org.apache.solr.SolrTestCase;
 import org.apache.solr.SolrTestCaseJ4;
@@ -31,6 +32,8 @@ import org.junit.Test;
  *
  * @since solr 1.3
  */
+@ThreadLeakLingering(linger = 250) // TODO something about this test very oddly allows an http2client-scheduler-1 to leak - it's in processworkerExit, tryTerminate, so
+// let's just try waiting for a moment until we can nail that down
 public class SolrExceptionTest extends SolrTestCase {
 
   @Test