You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/03/09 17:55:03 UTC
[GitHub] [accumulo] jmark99 opened a new pull request #2556: Create static private final Comparator for HostAndPort
jmark99 opened a new pull request #2556:
URL: https://github.com/apache/accumulo/pull/2556
Based upon suggestion in code review, created a static privae final
Comparator field to be used within the HostAndPort compareTo method
rather than constructing a new comparator each time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2556: Create static private final Comparator for HostAndPort
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #2556:
URL: https://github.com/apache/accumulo/pull/2556#issuecomment-1063352976
@jmark99 I don't think you ever answered my question at https://github.com/apache/accumulo/pull/2551#discussion_r822894763 or when I made the same observation earlier at https://github.com/apache/accumulo/pull/2551#discussion_r821784698
There are still no test cases where `null` is used as the host, and I'm not sure if this comparator will handle that case very nicely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jmark99 merged pull request #2556: Create static private final Comparator for HostAndPort
Posted by GitBox <gi...@apache.org>.
jmark99 merged pull request #2556:
URL: https://github.com/apache/accumulo/pull/2556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org