You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2014/06/10 19:22:11 UTC
git commit: Add note telling committers setup their git repo before
committing
Repository: hbase
Updated Branches:
refs/heads/master ee7622578 -> 4d200be62
Add note telling committers setup their git repo before committing
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/4d200be6
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/4d200be6
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/4d200be6
Branch: refs/heads/master
Commit: 4d200be620fb660b8b0a9c7bdcc15d59716fd156
Parents: ee76225
Author: Michael Stack <st...@apache.org>
Authored: Tue Jun 10 10:21:31 2014 -0700
Committer: Michael Stack <st...@apache.org>
Committed: Tue Jun 10 10:21:58 2014 -0700
----------------------------------------------------------------------
src/main/docbkx/developer.xml | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/4d200be6/src/main/docbkx/developer.xml
----------------------------------------------------------------------
diff --git a/src/main/docbkx/developer.xml b/src/main/docbkx/developer.xml
index e6dc79d..b0491ef 100644
--- a/src/main/docbkx/developer.xml
+++ b/src/main/docbkx/developer.xml
@@ -1599,8 +1599,17 @@ If a committer wishes to improve an unacceptable patch, then it should first be
<section xml:id="committing.patches">
<title>Commit</title>
-<para>Committers commit patches.
+<para>Committers commit patches to the Apache HBase GIT repository.
</para>
+<note>
+ <title>Before you commit!!!!</title>
+ <para>Make sure your local configuration is correct. In particular, your identity
+ and email. Do <command>$ git config --list</command>. Check what shows as your
+ <property>user.email</property> and <property>user.name</property>.
+ See this GitHub article, <link xlink:href="https://help.github.com/articles/set-up-git">Set Up Git</link>
+ if you need pointers.
+ </para>
+</note>
<para>When you commit a patch, please: </para><orderedlist numeration="arabic">
<listitem><para>Include the Jira issue id in the commit message, along with a short description of the change and the name of the contributor if it is not you.
Be sure to get the issue id right, as this causes Jira to link to the change in Subversion (use the issue's "All" tab to see these). </para></listitem>