You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/04/29 14:14:35 UTC

Review Request 20836: Unit tests for object_utils, date, ui_effects, updater

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20836/
-----------------------------------------------------------

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-5612
    https://issues.apache.org/jira/browse/AMBARI-5612


Repository: ambari


Description
-------

Create unit tests for following files:
* utils/object.js
* utils/date_utils.js
* utils/ui_effects_utils.js
* utils/updater.js


Diffs
-----

  ambari-web/app/assets/test/tests.js 7e8c040 
  ambari-web/app/utils/date.js 37d8959 
  ambari-web/app/utils/object_utils.js f215471 
  ambari-web/app/utils/ui_effects.js 57c431e 
  ambari-web/app/views/main/service/info/metrics/yarn/qmr.js b923d19 
  ambari-web/test/utils/date_test.js b67b176 
  ambari-web/test/utils/object_utils_test.js PRE-CREATION 
  ambari-web/test/utils/ui_effects_test.js PRE-CREATION 
  ambari-web/test/utils/updater_test.js PRE-CREATION 

Diff: https://reviews.apache.org/r/20836/diff/


Testing
-------

4185 tests complete (5 seconds)


Thanks,

Oleg Nechiporenko

Re: Review Request 20836: Unit tests for object_utils, date, ui_effects, updater

Posted by Andrii Tkach <at...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20836/#review41705
-----------------------------------------------------------

Ship it!


Ship It!

- Andrii Tkach


On April 29, 2014, 12:14 p.m., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20836/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 12:14 p.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-5612
>     https://issues.apache.org/jira/browse/AMBARI-5612
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create unit tests for following files:
> * utils/object.js
> * utils/date_utils.js
> * utils/ui_effects_utils.js
> * utils/updater.js
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 7e8c040 
>   ambari-web/app/utils/date.js 37d8959 
>   ambari-web/app/utils/object_utils.js f215471 
>   ambari-web/app/utils/ui_effects.js 57c431e 
>   ambari-web/app/views/main/service/info/metrics/yarn/qmr.js b923d19 
>   ambari-web/test/utils/date_test.js b67b176 
>   ambari-web/test/utils/object_utils_test.js PRE-CREATION 
>   ambari-web/test/utils/ui_effects_test.js PRE-CREATION 
>   ambari-web/test/utils/updater_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20836/diff/
> 
> 
> Testing
> -------
> 
> 4185 tests complete (5 seconds)
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>