You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/04 21:14:57 UTC
[GitHub] [netbeans] emilianbold opened a new pull request #2732: foojay discovery service integration into NetBeans IDE
emilianbold opened a new pull request #2732:
URL: https://github.com/apache/netbeans/pull/2732
foojay has a nice plugin in development which cannot call java.j2seplatform APIs without being a friend.
This PR adds the plugin to the friend list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold edited a comment on pull request #2732: Makes java.j2seplatform API / SPI public
Posted by GitBox <gi...@apache.org>.
emilianbold edited a comment on pull request #2732:
URL: https://github.com/apache/netbeans/pull/2732#issuecomment-773986941
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold commented on pull request #2732: Makes java.j2seplatform API / SPI public
Posted by GitBox <gi...@apache.org>.
emilianbold commented on pull request #2732:
URL: https://github.com/apache/netbeans/pull/2732#issuecomment-782614394
Wondering if there's something more that needs to be done here? I see @JaroslavTulach is pleased with the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2732: foojay discovery service integration into NetBeans IDE
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2732:
URL: https://github.com/apache/netbeans/pull/2732#issuecomment-773770322
CCing @tzezula - yes, it would be better to make the necessary API public rather than adding next friend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2732: foojay discovery service integration into NetBeans IDE
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2732:
URL: https://github.com/apache/netbeans/pull/2732#issuecomment-773999233
I am seeing following classes in the API: `J2SEPlatformCreator`, `J2SEPlatformDefaultJavadoc`, `J2SEPlatformDefaultSources`, that's a reasonable size, I guess.
> Is these still some API review process?
Just a regular review before integration with more attention to API aspects.
> would org-netbeans-modules-java-j2seplatform.sig need any tweaks?
No. Keep it unchanged.
> should I go and remove impl dependencies for existing friends
Hopefully there are no "implementation" dependencies. Friend modules use a regular dependency. You can keep it unchanged, but:
- you need to version your change - see [this essay](http://wiki.apidesign.org/wiki/FriendDependencies) - otherwise your module would get `NoClassDefFoundError`
- add an `apichanges.xml` entry describing the module went public
- your module has to depend on the new version that made this module public
- change `arch.xml` to say the API is public
- make sure the module is listed among public API modules in `nbbuild/build.properties`
- try to build `ant build-javadoc` to verify everything looks sane at the end
I am assuming your module is going to download and install various JDKs. Good luck with it! I hope to see it on our plugin portal soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold commented on pull request #2732: foojay discovery service integration into NetBeans IDE
Posted by GitBox <gi...@apache.org>.
emilianbold commented on pull request #2732:
URL: https://github.com/apache/netbeans/pull/2732#issuecomment-774333559
@JaroslavTulach I hope the apichanges are fine.
The Javadoc looks OK to me, no more red/'friend' link.
I don't know what to do about the new lines with `javadoc.docs.org-netbeans-modules-java-j2seplatform` added to these files:
* nbbuild/javadoctools/links.xml
* nbbuild/javadoctools/properties.xml
* nbbuild/javadoctools/replaces.xml
Should they also be committed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2732: foojay discovery service integration into NetBeans IDE
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2732:
URL: https://github.com/apache/netbeans/pull/2732#issuecomment-773770322
CCing @tzezula - yes, it would be better to make the necessary API public rather than adding next friend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2732: foojay discovery service integration into NetBeans IDE
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2732:
URL: https://github.com/apache/netbeans/pull/2732#issuecomment-773633698
I'm inclined to -1 on this. IMO we shouldn't be adding any more external friends to modules. That's just API by the backdoor. What are the barriers to making what's required public?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold commented on pull request #2732: foojay discovery service integration into NetBeans IDE
Posted by GitBox <gi...@apache.org>.
emilianbold commented on pull request #2732:
URL: https://github.com/apache/netbeans/pull/2732#issuecomment-773986941
I made the friend packages into public packages. Builds locally, let's see what the CI says.
I wonder:
* [ ] Is these still some API review process? The existing API/SPI packages are quite old.
* [ ] would `org-netbeans-modules-java-j2seplatform.sig` need any tweaks? I would seem not, but I never looked into that.
* [ ] should I go and remove impl dependencies for existing friends modules? This seems optional to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold edited a comment on pull request #2732: Makes java.j2seplatform API / SPI public
Posted by GitBox <gi...@apache.org>.
emilianbold edited a comment on pull request #2732:
URL: https://github.com/apache/netbeans/pull/2732#issuecomment-773986941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2732: foojay discovery service integration into NetBeans IDE
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2732:
URL: https://github.com/apache/netbeans/pull/2732#issuecomment-773633698
I'm inclined to -1 on this. IMO we shouldn't be adding any more external friends to modules. That's just API by the backdoor. What are the barriers to making what's required public?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw merged pull request #2732: Makes java.j2seplatform API / SPI public
Posted by GitBox <gi...@apache.org>.
geertjanw merged pull request #2732:
URL: https://github.com/apache/netbeans/pull/2732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists