Re: [1/5] git commit: [flex-sdk] [refs/heads/develop] - Made findRenderer protected (it's useful!) and fixed issue with it not dealing with horizontal scroll position correctly.

[Alex Harui <ah...@adobe.com>]

Some good stuff in this set.

The diff makes it look like @private is still in the asdoc for a now
protected method.  Is that what you want?

-Alex

On 5/28/13 7:23 PM, "jmclean@apache.org" <jm...@apache.org> wrote:

>Updated Branches:
>  refs/heads/develop b709e3d31 -> b38f1419b
>
>
>Made findRenderer protected (it's useful!) and fixed issue with it not
>dealing with horizontal scroll position correctly.
>
>
>Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/e5194b09
>Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/e5194b09
>Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/e5194b09
>
>Branch: refs/heads/develop
>Commit: e5194b09222fb99c1b6e7b85cc1e7cc297862edc
>Parents: b709e3d
>Author: Justin Mclean <jm...@apache.org>
>Authored: Wed May 29 11:04:13 2013 +1000
>Committer: Justin Mclean <jm...@apache.org>
>Committed: Wed May 29 11:04:13 2013 +1000
>
>----------------------------------------------------------------------
> .../src/mx/controls/AdvancedDataGridBaseEx.as      |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>----------------------------------------------------------------------
>
>
>http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/e5194b09/frameworks/p
>rojects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as
>----------------------------------------------------------------------
>diff --git 
>a/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx
>.as 
>b/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx
>.as
>index d17518f..8b62546 100644
>--- 
>a/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx
>.as
>+++ 
>b/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx
>.as
>@@ -6195,7 +6195,7 @@ public class AdvancedDataGridBaseEx extends
>AdvancedDataGridBase implements IIME
>      *  
>      *  @private
>      */    
>-    private function
>findRenderer(pt:Point,items:Array,info:Array,yy:Number =
>0):IListItemRenderer
>+    protected function
>findRenderer(pt:Point,items:Array,info:Array,yy:Number =
>0):IListItemRenderer
>     {
>         var r:IListItemRenderer;
>         var ww:Number = 0;
>@@ -6216,7 +6216,7 @@ public class AdvancedDataGridBaseEx extends
>AdvancedDataGridBase implements IIME
>                     }
> 
>                     ww = 0;
>-                    for (var j:int = 0; j < m; j++)
>+                    for (var j:int = horizontalScrollPosition; j < m;
>j++)
>                     {
>                         ww += optimumColumns[j].width;
>                         if (pt.x < ww)
>

Re: [1/5] git commit: [flex-sdk] [refs/heads/develop] - Made findRenderer protected (it's useful!) and fixed issue with it not dealing with horizontal scroll position correctly.

[Justin Mclean <ju...@classsoftware.com>]

Hi,

> The diff makes it look like @private is still in the asdoc for a now
> protected method.  Is that what you want?

Not intentional I'll remove the @private.

Thanks,
Justin