You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Jacques Le Roux (Jira)" <ji...@apache.org> on 2021/11/08 19:36:00 UTC
[jira] [Commented] (OFBIZ-10553) Convert QuoteServices.xml mini
lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440709#comment-17440709 ]
Jacques Le Roux commented on OFBIZ-10553:
-----------------------------------------
Hi Nicolas,
Are we sure that's the best practice:
{code:xml}
<!--Duplicate the service createQuoteWorkEffort, the first inform the deprecation, the second override and work normally-->
<service name="createQuoteWorkEffort" default-entity-name="QuoteWorkEffort" engine="entity-auto" invoke="create" auth="true">
<deprecated use-instead="ensureWorkEffortAndCreateQuoteWorkEffort" since="Release 18.12">
use createQuoteWorkEffort to create a workeffort has been deprecated for best pratice naming reason, use ensureWorkEffortAndCreateQuoteWorkEffort instead.
Now createQuoteWorkEffort work as a crud service on QuoteWorkEffort
</deprecated>
</service>
<service name="createQuoteWorkEffort" default-entity-name="QuoteWorkEffort" engine="entity-auto" invoke="create" auth="true">
<description>Create a new QuoteWorkEffort</description>
<required-permissions join-type="AND">
<check-permission permission="ORDERMGR" action="_CREATE"/>
</required-permissions>
<auto-attributes mode="IN" include="pk"/>
</service>
{code}
gives in log:
|W| Service createQuoteWorkEffort is defined more than once, most recent will over-write previous definition(s)
Maybe we could do better? (not a big deal, more a question)
> Convert QuoteServices.xml mini lang to groovy
> ---------------------------------------------
>
> Key: OFBIZ-10553
> URL: https://issues.apache.org/jira/browse/OFBIZ-10553
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: Trunk
> Reporter: Antoine Ouvrard
> Assignee: Nicolas Malin
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10553.patch, OFBIZ-10553.patch
>
>
> This is an attempt to migrate QuoteServices.xml to groovy file version.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)