You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackyhu-db (via GitHub)" <gi...@apache.org> on 2025/07/12 00:16:49 UTC
[PR] chore(csharp/test/Drivers/Databricks): Fix some test cases that have null catalog [arrow-adbc]
jackyhu-db opened a new pull request, #3139:
URL: https://github.com/apache/arrow-adbc/pull/3139
## Issue
In some test cases in `DatabricksConnectionTest` and `StatementTest` in Databricks driver test, when catalog/schema is `null`, the test code does not update the corresponding catalog/schema in `TestConfiguration`, if the `catalog` or `schema` is non-empty in the original `TestConfiguration`, the test case will fail
## Changes
- Updated `DatabricksConnectionTest:SetDefaultCatalogAndSchemaOptionsTest` to set catalog/schema in testConfig to `string.empty` when catalog/schema is null
- Updated `StatementTest:ShouldReturnEmptyPkFkResult_WorksAsExpected` to set statement's catalog to `string.empty` when it is null
## Testing
- `Apache.Arrow.Adbc.Tests.Drivers.Databricks.DatabricksConnectionTest`
- `Apache.Arrow.Adbc.Tests.Drivers.Databricks.StatementTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(csharp/test/Drivers/Databricks): Fix some test cases that have null catalog [arrow-adbc]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher merged PR #3139:
URL: https://github.com/apache/arrow-adbc/pull/3139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(csharp/test/Drivers/Databricks): Fix some test cases that have null catalog [arrow-adbc]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on code in PR #3139:
URL: https://github.com/apache/arrow-adbc/pull/3139#discussion_r2202269307
##########
csharp/test/Drivers/Databricks/E2E/DatabricksConnectionTest.cs:
##########
@@ -373,8 +373,21 @@ public async Task SetDefaultCatalogAndSchemaOptionsTest(string? inputCatalog, st
var testConfig = (DatabricksTestConfiguration)TestConfiguration.Clone();
testConfig.EnableMultipleCatalogSupport = enableMultipleCatalogSupport;
- if (inputCatalog is not null) testConfig.Catalog = inputCatalog;
- if (inputSchema is not null) testConfig.DbSchema = inputSchema;
+ if (inputCatalog is not null)
+ {
+ testConfig.Catalog = inputCatalog;
+ } else
Review Comment:
nit: add newline before else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org