You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Jan Willem Janssen <ja...@luminis.eu> on 2012/07/18 12:36:27 UTC
[donation] UserAdmin implementation
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi list,
I've written a UserAdmin implementation that I'd like to donate to the
Felix project, see [1].
One of the main reasons for writing another implementation is that all
current implementations seems to have serious performance issues and
the lack of a proper test suite.
As I've also written in the JIRA issue, I'm willing to maintain this
implementation in the future if needed.
One question I've got about this donation: does it need to include a
Software Grant document as well? I'm already an Apache committer for
the ACE project, so I'm not entirely sure it is necessary?!
[1] https://issues.apache.org/jira/browse/FELIX-3600
- --
Met vriendelijke groeten | Kind regards
Jan Willem Janssen | Software Architect
+31 631 765 814
/My world is:/
Luminis Technologies B.V.
IJsselburcht 3
6825 BS Arnhem
+31 88 586 46 30
http://www.luminis-technologies.com
http://www.luminis.eu
KvK (CoC) 09 16 28 93
BTW (VAT) NL8169.78.566.B.01
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJQBpGrAAoJEKF/mP2eHDc4xmAP/38F7UayT6OlvMYdiR+ZRq6h
qR4AvUHuikxIreT7p3kqFSrw1uzV56jI4bCmsnDPE0likG6ac1Oh3IpczFz0ggXS
YRiYOojnJ5p78VtXE3zswyzou0bzblVwb1F7k5jPuh3ptgzg1oGsRIcbs1PkK+OR
UUcpLc+ZOY0jO4nH7J9e1wPbdwHzWdU6t8qvRDqERmtTlA+FZ7FJVpdx1d7X50g/
hZgWTPvpAAI3/sVXsqvTn9FJDbDYusu4L3R+pJxx/dmeHwigTmimZAB+cQZ1+Ozo
NSD8uLL8JE56g+M0T3xN0Kyfl40Lzuxo7U4xu8RyXkFCEzt+gdRMbaFJtgvrwlWc
9atvh5AvhOnfo8IcUbTZxTTwAi+fLUirq0PyfCOuIhbeilECI5yXBgJqDXF/mZat
myvoa2NSR8uzdQaBEoT6U2wUQGzxNvCmuNPwtXT0OocG9WbksWcA94lp9Q0SNVdE
DGoqkqZZHXWP5nc2zWIiiS+qpVJEMl8kinTMl6ixT8b5mPQLnTtV6vJDXcMRZeL0
DexnxIyjxx4D9ygGsBoxWWziaOENI3rq6M1paLqNM0ca0QV7pa2GdRic+jBKFjs3
kqjN5oPYDJG4IO3BSmixn/tyRX/VEE0wAcPl2a/oh1d7Zc79ul9WHyhq0pwkIEci
921tazccS8gJ2IEo53rk
=R/ja
-----END PGP SIGNATURE-----
Re: [donation] UserAdmin implementation
Posted by Jan Willem Janssen <ja...@luminis.eu>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 7/19/12 3:52 PM, Peter Kriens wrote:
> Will it include a mongodb backend?
I've updated the JIRA issue with a store implemenation for MongoDB.
I'd like to contribute it along with the original User Admin contribution.
- --
Met vriendelijke groeten | Kind regards
Jan Willem Janssen | Software Architect
+31 631 765 814
/My world is:/
Luminis Technologies B.V.
IJsselburcht 3
6825 BS Arnhem
+31 88 586 46 30
http://www.luminis-technologies.com
http://www.luminis.eu
KvK (CoC) 09 16 28 93
BTW (VAT) NL8169.78.566.B.01
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJQEV3+AAoJEKF/mP2eHDc4p24P/2OSTMgFJdBUqARRZlKQCtBS
srzKxN+1M4TaqblSyImRaXIuMAmzULtse2BOTgsioXX2tukR/6I64RuT6X0RSjWC
mEclx/Im7XIDJbJS+18807GNMUZbMihqhJKFs274SWXQh2DhlsN7h2HNzGSPBLXW
lZtIxj+1oyZjJtJc8GMXdZ/E994h9pgXnRrRSfZpQWDIUmOo17QsjEDJRaAYeD9f
cvzMDuNRR4vJJ/6gaitbb5gwlhMRiSjhZPZSPSm0VWKyf4Gmqu8ZQPe+z3uW6aFa
XXae2klc7OdRGVLQUt0HR0LZPK4MMl/y+CmStyJHiVB8oGihENsc4V3hWn8bQYwz
/duiGoIjeUVKoFsFIXx0sBbyJkt3HZ3gInNWY1iJWY415+601Dj8/VXPbAjhDszi
YTMGpiqmZV5QsMiHvMRnkjKUTwLKWQKkm4Bdxa/qfQusYWqdjXsMv2V1yI+uwWNZ
kEAeDMwsCF8eI39+124qP23pi40SORIYd1UDaKJCMzRBjmFOPdscRh1x6k5gLmwE
Dl2e/bnmAC51MpoECRBIZQP6HWZctI9GLFQ3tURPJcQ6C9QB84Kt5d/q3YGTt8+0
px/m41P/gJ/psUsvWem8X+8yhKH+T5h/Zi4GrKnX9d0ZLgWnpAaDGl9CiX97HNDU
s7K7dUeOuXIMVh1gNVVD
=0kNj
-----END PGP SIGNATURE-----
Re: [donation] UserAdmin implementation
Posted by Jan Willem Janssen <ja...@luminis.eu>.
On 7/19/12 3:52 PM, Peter Kriens wrote:
> It comes as a godsend ... :-) I do highly support including this
> in Apache.
>
> Will it include a mongodb backend?
Funny, I asked to implement a MongoDB backend just this week. I'm not
sure how generic it can be to be included with the default UA...
--
Met vriendelijke groeten | Kind regards
Jan Willem Janssen | Software Architect
+31 631 765 814
/My world is:/
Luminis Technologies B.V.
IJsselburcht 3
6825 BS Arnhem
+31 88 586 46 30
http://www.luminis-technologies.com
http://www.luminis.eu
KvK (CoC) 09 16 28 93
BTW (VAT) NL8169.78.566.B.01
Re: [donation] UserAdmin implementation
Posted by Peter Kriens <pe...@aqute.biz>.
It comes as a godsend ... :-) I do highly support including this in Apache.
Will it include a mongodb backend?
Kind regards,
Peter Kriens
On 18 jul. 2012, at 12:36, Jan Willem Janssen wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi list,
>
> I've written a UserAdmin implementation that I'd like to donate to the
> Felix project, see [1].
>
> One of the main reasons for writing another implementation is that all
> current implementations seems to have serious performance issues and
> the lack of a proper test suite.
>
> As I've also written in the JIRA issue, I'm willing to maintain this
> implementation in the future if needed.
>
> One question I've got about this donation: does it need to include a
> Software Grant document as well? I'm already an Apache committer for
> the ACE project, so I'm not entirely sure it is necessary?!
>
> [1] https://issues.apache.org/jira/browse/FELIX-3600
>
> - --
> Met vriendelijke groeten | Kind regards
>
> Jan Willem Janssen | Software Architect
> +31 631 765 814
>
> /My world is:/
>
> Luminis Technologies B.V.
> IJsselburcht 3
> 6825 BS Arnhem
> +31 88 586 46 30
>
> http://www.luminis-technologies.com
> http://www.luminis.eu
>
> KvK (CoC) 09 16 28 93
> BTW (VAT) NL8169.78.566.B.01
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
> Comment: GPGTools - http://gpgtools.org
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQIcBAEBAgAGBQJQBpGrAAoJEKF/mP2eHDc4xmAP/38F7UayT6OlvMYdiR+ZRq6h
> qR4AvUHuikxIreT7p3kqFSrw1uzV56jI4bCmsnDPE0likG6ac1Oh3IpczFz0ggXS
> YRiYOojnJ5p78VtXE3zswyzou0bzblVwb1F7k5jPuh3ptgzg1oGsRIcbs1PkK+OR
> UUcpLc+ZOY0jO4nH7J9e1wPbdwHzWdU6t8qvRDqERmtTlA+FZ7FJVpdx1d7X50g/
> hZgWTPvpAAI3/sVXsqvTn9FJDbDYusu4L3R+pJxx/dmeHwigTmimZAB+cQZ1+Ozo
> NSD8uLL8JE56g+M0T3xN0Kyfl40Lzuxo7U4xu8RyXkFCEzt+gdRMbaFJtgvrwlWc
> 9atvh5AvhOnfo8IcUbTZxTTwAi+fLUirq0PyfCOuIhbeilECI5yXBgJqDXF/mZat
> myvoa2NSR8uzdQaBEoT6U2wUQGzxNvCmuNPwtXT0OocG9WbksWcA94lp9Q0SNVdE
> DGoqkqZZHXWP5nc2zWIiiS+qpVJEMl8kinTMl6ixT8b5mPQLnTtV6vJDXcMRZeL0
> DexnxIyjxx4D9ygGsBoxWWziaOENI3rq6M1paLqNM0ca0QV7pa2GdRic+jBKFjs3
> kqjN5oPYDJG4IO3BSmixn/tyRX/VEE0wAcPl2a/oh1d7Zc79ul9WHyhq0pwkIEci
> 921tazccS8gJ2IEo53rk
> =R/ja
> -----END PGP SIGNATURE-----
>
Re: [donation] UserAdmin implementation
Posted by Jan Willem Janssen <ja...@luminis.eu>.
On 7/19/12 5:26 PM, Felix Meschberger wrote:
> Hi,
>
> Am 18.07.2012 um 19:26 schrieb Richard S. Hall:
>
>> On 7/18/12 12:08 , Marcel Offermans wrote:
>>> On 7/18/12 06:36 , Jan Willem Janssen wrote:
>>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>>>>
>>>> Hi list,
>>>>
>>>> I've written a UserAdmin implementation that I'd like to
>>>> donate to the Felix project, see [1].
>>>
>>>> [1] https://issues.apache.org/jira/browse/FELIX-3600
>>> Thanks, Jan Willem, I took a look at the code and all the tests
>>> (over 200, wow!) and it's definitely looking good to me. It
>>> also has a plugable store backend, which is nice if people want
>>> to hook it up to existing databases and repositories. I think
>>> we should definitely accept this donation!
>>
>> I'm inclined to agree...
>
> So am I.
>
> The RoleChangeListener.java is missing the ASL header and the
> bundle plugin configuration IMHO needs some tweeking (e.b.
> versioning the package export, replacing Export-Service by the
> respective Capability header)
Ok; I've apparently missed those. I'll update them, and include a new
(signed) version in the JIRA issue.
Thanks for looking into this!
--
Met vriendelijke groeten | Kind regards
Jan Willem Janssen | Software Architect
+31 631 765 814
/My world is:/
Luminis Technologies B.V.
IJsselburcht 3
6825 BS Arnhem
+31 88 586 46 30
http://www.luminis-technologies.com
http://www.luminis.eu
KvK (CoC) 09 16 28 93
BTW (VAT) NL8169.78.566.B.01
Re: [donation] UserAdmin implementation
Posted by Felix Meschberger <fm...@adobe.com>.
Hi,
Am 18.07.2012 um 19:26 schrieb Richard S. Hall:
> On 7/18/12 12:08 , Marcel Offermans wrote:
>> On 7/18/12 06:36 , Jan Willem Janssen wrote:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> Hi list,
>>>
>>> I've written a UserAdmin implementation that I'd like to donate to the
>>> Felix project, see [1].
>>
>>> [1] https://issues.apache.org/jira/browse/FELIX-3600
>> Thanks, Jan Willem, I took a look at the code and all the tests (over 200, wow!) and it's definitely looking good to me. It also has a plugable store backend, which is nice if people want to hook it up to existing databases and repositories. I think we should definitely accept this donation!
>
> I'm inclined to agree...
So am I.
The RoleChangeListener.java is missing the ASL header and the bundle plugin configuration IMHO needs some tweeking (e.b. versioning the package export, replacing Export-Service by the respective Capability header)
Regards
Felix
>
> -> richard
>
>>
>> Greetings, Marcel
>>
>>
>
>
Re: [donation] UserAdmin implementation
Posted by "Richard S. Hall" <he...@ungoverned.org>.
On 7/18/12 12:08 , Marcel Offermans wrote:
> On 7/18/12 06:36 , Jan Willem Janssen wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hi list,
>>
>> I've written a UserAdmin implementation that I'd like to donate to the
>> Felix project, see [1].
>
>> [1] https://issues.apache.org/jira/browse/FELIX-3600
> Thanks, Jan Willem, I took a look at the code and all the tests (over 200, wow!) and it's definitely looking good to me. It also has a plugable store backend, which is nice if people want to hook it up to existing databases and repositories. I think we should definitely accept this donation!
I'm inclined to agree...
-> richard
>
> Greetings, Marcel
>
>
Re: [donation] UserAdmin implementation
Posted by Marcel Offermans <ma...@luminis.nl>.
On 7/18/12 06:36 , Jan Willem Janssen wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi list,
>
> I've written a UserAdmin implementation that I'd like to donate to the
> Felix project, see [1].
> [1] https://issues.apache.org/jira/browse/FELIX-3600
Thanks, Jan Willem, I took a look at the code and all the tests (over 200, wow!) and it's definitely looking good to me. It also has a plugable store backend, which is nice if people want to hook it up to existing databases and repositories. I think we should definitely accept this donation!
Greetings, Marcel
Re: [donation] UserAdmin implementation
Posted by Jan Willem Janssen <ja...@luminis.eu>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 7/18/12 4:55 PM, Richard S. Hall wrote:
> On 7/18/12 06:36 , Jan Willem Janssen wrote: Hi list,
>
> I've written a UserAdmin implementation that I'd like to donate to
> the Felix project, see [1].
>
> One of the main reasons for writing another implementation is that
> all current implementations seems to have serious performance
> issues and the lack of a proper test suite.
>
> As I've also written in the JIRA issue, I'm willing to maintain
> this implementation in the future if needed.
>
>> Sounds good.
>
>
> One question I've got about this donation: does it need to include
> a Software Grant document as well? I'm already an Apache committer
> for the ACE project, so I'm not entirely sure it is necessary?!
>
>> Ultimately, it needs to be voted on and accepted by the community
>> before you need to worry about a grant, but if it is accepted,
>> then it will need a grant.
Ok; I'll wait for the discussion and vote to settle down...
>> See this document for the steps:
>
>> http://felix.apache.org/site/contributing-source-code.html
Who is going to create the IP-clearance for contributions, the person
submitting the code, or a PMC member from the project?
- --
Met vriendelijke groeten | Kind regards
Jan Willem Janssen | Software Architect
+31 631 765 814
/My world is:/
Luminis Technologies B.V.
IJsselburcht 3
6825 BS Arnhem
+31 88 586 46 30
http://www.luminis-technologies.com
http://www.luminis.eu
KvK (CoC) 09 16 28 93
BTW (VAT) NL8169.78.566.B.01
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJQBt1gAAoJEKF/mP2eHDc4lrUP/RdjCKWkh4XcaZ0DDeMGgaLb
C5ZH5X/ptPvf35OBzlUzJYOmW7xoT8Uu7KrtGvG4JFyv6jKIqbAMKZVX5MFfCy6Z
+gxm3h6iCcDybI5+8YzmJ/NmRvVNKIzDnrtY7IthW5qQ8ay6/v/Avyc3TFd0qFlI
LJDDMGDA0ItCoPD6/LqRaMAx+oV0n3JzqQrG3hMpJoe8kBPim2sk3V2eyvOXlw9s
AUCdOrZXVFIeb5l9m5bL1ZYj0GvtbTM9FTY+7Mt7ZxgNXKP7QvfCb2gFzXOJUyHG
rAfFbmZQw+E8ws1jzCoxJm49Hx4i6kLgPPvQ0rbMp+bZ+xnZDPW3XGfZW1EnJU5W
1t+cT4hOJTLy+IewXcfSeyQAMHWK7uXpt6a32wxHHMFFWewU1ZQM6Z7qWIBgnn6F
n9mPM7qTSD4B/dFCX18EZ04jAxBtTx3nhqBkYKtGYPKNpLllkS9aadx9Iv62wXf9
3ZQZm1csnFkrHOgfkKW1CSOKSnqyf/65Yzy6PNaioevWyz7g7BFanJclOTCtLN/U
DdqD9Qvir4QQpLMQnM3XbLlykkMKosrsAkeWeDd1RXRthwmUIgisAXvi6N6DUSB1
MND/CgUvS+XuKboSjAVxZcy8RdR1VlvakLzPdoRNjGizwJaUIUMQUaQ86SnKwL91
VgdNaX2OOaID0MToRefJ
=IhKx
-----END PGP SIGNATURE-----
Re: [donation] UserAdmin implementation
Posted by "Richard S. Hall" <he...@ungoverned.org>.
On 7/18/12 06:36 , Jan Willem Janssen wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi list,
>
> I've written a UserAdmin implementation that I'd like to donate to the
> Felix project, see [1].
>
> One of the main reasons for writing another implementation is that all
> current implementations seems to have serious performance issues and
> the lack of a proper test suite.
>
> As I've also written in the JIRA issue, I'm willing to maintain this
> implementation in the future if needed.
Sounds good.
>
> One question I've got about this donation: does it need to include a
> Software Grant document as well? I'm already an Apache committer for
> the ACE project, so I'm not entirely sure it is necessary?!
Ultimately, it needs to be voted on and accepted by the community before
you need to worry about a grant, but if it is accepted, then it will
need a grant.
See this document for the steps:
http://felix.apache.org/site/contributing-source-code.html
-> richard
>
> [1] https://issues.apache.org/jira/browse/FELIX-3600
>
> - --
> Met vriendelijke groeten | Kind regards
>
> Jan Willem Janssen | Software Architect
> +31 631 765 814
>
> /My world is:/
>
> Luminis Technologies B.V.
> IJsselburcht 3
> 6825 BS Arnhem
> +31 88 586 46 30
>
> http://www.luminis-technologies.com
> http://www.luminis.eu
>
> KvK (CoC) 09 16 28 93
> BTW (VAT) NL8169.78.566.B.01
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
> Comment: GPGTools - http://gpgtools.org
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQIcBAEBAgAGBQJQBpGrAAoJEKF/mP2eHDc4xmAP/38F7UayT6OlvMYdiR+ZRq6h
> qR4AvUHuikxIreT7p3kqFSrw1uzV56jI4bCmsnDPE0likG6ac1Oh3IpczFz0ggXS
> YRiYOojnJ5p78VtXE3zswyzou0bzblVwb1F7k5jPuh3ptgzg1oGsRIcbs1PkK+OR
> UUcpLc+ZOY0jO4nH7J9e1wPbdwHzWdU6t8qvRDqERmtTlA+FZ7FJVpdx1d7X50g/
> hZgWTPvpAAI3/sVXsqvTn9FJDbDYusu4L3R+pJxx/dmeHwigTmimZAB+cQZ1+Ozo
> NSD8uLL8JE56g+M0T3xN0Kyfl40Lzuxo7U4xu8RyXkFCEzt+gdRMbaFJtgvrwlWc
> 9atvh5AvhOnfo8IcUbTZxTTwAi+fLUirq0PyfCOuIhbeilECI5yXBgJqDXF/mZat
> myvoa2NSR8uzdQaBEoT6U2wUQGzxNvCmuNPwtXT0OocG9WbksWcA94lp9Q0SNVdE
> DGoqkqZZHXWP5nc2zWIiiS+qpVJEMl8kinTMl6ixT8b5mPQLnTtV6vJDXcMRZeL0
> DexnxIyjxx4D9ygGsBoxWWziaOENI3rq6M1paLqNM0ca0QV7pa2GdRic+jBKFjs3
> kqjN5oPYDJG4IO3BSmixn/tyRX/VEE0wAcPl2a/oh1d7Zc79ul9WHyhq0pwkIEci
> 921tazccS8gJ2IEo53rk
> =R/ja
> -----END PGP SIGNATURE-----
>