You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/02/02 20:24:18 UTC

[jira] Created: (HADOOP-6534) LocalDirAllocator should use whitespace trimming configuration getters

LocalDirAllocator should use whitespace trimming configuration getters
----------------------------------------------------------------------

                 Key: HADOOP-6534
                 URL: https://issues.apache.org/jira/browse/HADOOP-6534
             Project: Hadoop Common
          Issue Type: Improvement
          Components: conf, fs
    Affects Versions: 0.21.0, 0.22.0
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon


This is the other half of MAPREDUCE-1441. If a user specifies mapred.local.dir with whitespace around directory names, it should be trimmed. Same goes for any LocalDirAllocator-based configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6534) LocalDirAllocator should use whitespace trimming configuration getters

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833390#action_12833390 ] 

Hudson commented on HADOOP-6534:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #167 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/167/])
    . Trim whitespace from directory lists initializing
LocalDirAllocator. Contributed by Todd Lipcon


> LocalDirAllocator should use whitespace trimming configuration getters
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6534
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6534
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, fs
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6534.txt
>
>
> This is the other half of MAPREDUCE-1441. If a user specifies mapred.local.dir with whitespace around directory names, it should be trimmed. Same goes for any LocalDirAllocator-based configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6534) LocalDirAllocator should use whitespace trimming configuration getters

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828810#action_12828810 ] 

Tom White commented on HADOOP-6534:
-----------------------------------

+1

> LocalDirAllocator should use whitespace trimming configuration getters
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6534
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6534
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, fs
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-6534.txt
>
>
> This is the other half of MAPREDUCE-1441. If a user specifies mapred.local.dir with whitespace around directory names, it should be trimmed. Same goes for any LocalDirAllocator-based configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6534) LocalDirAllocator should use whitespace trimming configuration getters

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833553#action_12833553 ] 

Hudson commented on HADOOP-6534:
--------------------------------

Integrated in Hadoop-Common-trunk #249 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/249/])
    . Trim whitespace from directory lists initializing
LocalDirAllocator. Contributed by Todd Lipcon


> LocalDirAllocator should use whitespace trimming configuration getters
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6534
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6534
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, fs
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6534.txt
>
>
> This is the other half of MAPREDUCE-1441. If a user specifies mapred.local.dir with whitespace around directory names, it should be trimmed. Same goes for any LocalDirAllocator-based configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6534) LocalDirAllocator should use whitespace trimming configuration getters

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-6534:
--------------------------------

    Status: Patch Available  (was: Open)

> LocalDirAllocator should use whitespace trimming configuration getters
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6534
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6534
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, fs
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-6534.txt
>
>
> This is the other half of MAPREDUCE-1441. If a user specifies mapred.local.dir with whitespace around directory names, it should be trimmed. Same goes for any LocalDirAllocator-based configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6534) LocalDirAllocator should use whitespace trimming configuration getters

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-6534:
--------------------------------

    Attachment: hadoop-6534.txt

> LocalDirAllocator should use whitespace trimming configuration getters
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6534
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6534
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, fs
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-6534.txt
>
>
> This is the other half of MAPREDUCE-1441. If a user specifies mapred.local.dir with whitespace around directory names, it should be trimmed. Same goes for any LocalDirAllocator-based configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6534) LocalDirAllocator should use whitespace trimming configuration getters

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828751#action_12828751 ] 

Todd Lipcon commented on HADOOP-6534:
-------------------------------------

Don't think this needs tests of its own - the change is trivial and the method in Configuration is already tested.

> LocalDirAllocator should use whitespace trimming configuration getters
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6534
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6534
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, fs
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-6534.txt
>
>
> This is the other half of MAPREDUCE-1441. If a user specifies mapred.local.dir with whitespace around directory names, it should be trimmed. Same goes for any LocalDirAllocator-based configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6534) LocalDirAllocator should use whitespace trimming configuration getters

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-6534:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.22.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

+1

I committed this. Thanks, Todd!

> LocalDirAllocator should use whitespace trimming configuration getters
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6534
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6534
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, fs
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6534.txt
>
>
> This is the other half of MAPREDUCE-1441. If a user specifies mapred.local.dir with whitespace around directory names, it should be trimmed. Same goes for any LocalDirAllocator-based configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6534) LocalDirAllocator should use whitespace trimming configuration getters

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828749#action_12828749 ] 

Hadoop QA commented on HADOOP-6534:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12434577/hadoop-6534.txt
  against trunk revision 904975.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/315/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/315/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/315/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/315/console

This message is automatically generated.

> LocalDirAllocator should use whitespace trimming configuration getters
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6534
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6534
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, fs
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-6534.txt
>
>
> This is the other half of MAPREDUCE-1441. If a user specifies mapred.local.dir with whitespace around directory names, it should be trimmed. Same goes for any LocalDirAllocator-based configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.