[GitHub] [airflow] KevinYang21 commented on a change in pull request #5048: [AIRFLOW-3370] Add stdout output options to Elasticsearch task log handler

[GitBox <gi...@apache.org>]

KevinYang21 commented on a change in pull request #5048: [AIRFLOW-3370] Add stdout output options to Elasticsearch task log handler
URL: https://github.com/apache/airflow/pull/5048#discussion_r277240795
 
 

 ##########
 File path: airflow/utils/log/es_task_handler.py
 ##########
 @@ -119,7 +146,10 @@ def _read(self, ti, try_number, metadata=None):
         if offset != next_offset or 'last_log_timestamp' not in metadata:
             metadata['last_log_timestamp'] = str(cur_ts)
 
-        message = '\n'.join([log.message for log in logs])
+        # If we hit the end of the log, remove the actual end_of_log message
 
 Review comment:
   nice one, was hardcoding a `u'\u0004\n'` in our logging config to prevent the mark from being displayed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services