You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by lw-lin <gi...@git.apache.org> on 2016/03/10 15:10:59 UTC
[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...
GitHub user lw-lin opened a pull request:
https://github.com/apache/spark/pull/11634
[SPARK-13618][STREAMING][WEB-UI] Make Streaming web UI page display rate-limit lines on statistics graph - Part 3
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lw-lin/spark display-rate-limit-on-streaming-web-ui-part-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11634.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11634
----
commit 720f2d432cd65c5a3ff82dce08f640a110658e7e
Author: proflin <pr...@gmail.com>
Date: 2016-03-10T12:53:53Z
Collect rate limit numbers on executor side
commit e408e4f5be19c479ce92bdc70360d5fbee7044dd
Author: proflin <pr...@gmail.com>
Date: 2016-03-10T13:29:00Z
Add InputDStream.underRateLimit field
commit e04ec30be52d06d27d5265c247090bcd34f36246
Author: proflin <pr...@gmail.com>
Date: 2016-03-10T13:29:50Z
Merge commit '720f2d432cd65c5a3ff82dce08f640a110658e7e' into rate-5-3
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11634#issuecomment-194998940
**[Test build #2629 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2629/consoleFull)** for PR 11634 at commit [`b77df2e`](https://github.com/apache/spark/commit/b77df2e1a1c90ba518b25ca00a46559f398977b8).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class StreamInputInfo(inputStreamId: Int,`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11634#issuecomment-194998061
**[Test build #2629 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2629/consoleFull)** for PR 11634 at commit [`b77df2e`](https://github.com/apache/spark/commit/b77df2e1a1c90ba518b25ca00a46559f398977b8).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...
Posted by lw-lin <gi...@git.apache.org>.
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11634#issuecomment-194881087
All three parts are now ready for review. I've also drafted a design doc (please see [Spark-13618](https://issues.apache.org/jira/browse/SPARK-13618)), hopefully it can help reviewers review this more faster.
@tdas @zsxwing would you mind taking a look when you have time? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11634#issuecomment-194862798
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13618][STREAMING][WEB-UI] Make Streamin...
Posted by lw-lin <gi...@git.apache.org>.
Github user lw-lin closed the pull request at:
https://github.com/apache/spark/pull/11634
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org