You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by keith-turner <gi...@git.apache.org> on 2016/10/04 23:54:18 UTC
[GitHub] incubator-fluo-recipes pull request #110: Reviewed APIs in prep for 1.0 rele...
GitHub user keith-turner opened a pull request:
https://github.com/apache/incubator-fluo-recipes/pull/110
Reviewed APIs in prep for 1.0 release. Made two small changes.
* Made it easier to do table optimizations for any recipe
* Made type layer increment return old value
* Optimized some code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keith-turner/fluo-recipes pre-release-review
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fluo-recipes/pull/110.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #110
----
commit 55a4bbf23b0d1549242e9323976ab72d0b75c850
Author: Keith Turner <kt...@apache.org>
Date: 2016-10-04T20:01:32Z
Reviewed APIs in prep for 1.0 release. Made two small changes.
* Made it easier to do table optimizations for any recipe
* Made type layer increment return old value
* Optimized some code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-recipes pull request #110: Reviewed APIs in prep for 1.0 rele...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-fluo-recipes/pull/110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-recipes pull request #110: Reviewed APIs in prep for 1.0 rele...
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-recipes/pull/110#discussion_r81878406
--- Diff: modules/core/src/main/java/org/apache/fluo/recipes/core/types/TypedSnapshotBase.java ---
@@ -229,6 +229,17 @@ public ByteBuffer toByteBuffer(ByteBuffer defaultValue) {
return toByteBuffer();
}
+ public <T> T toObject(Class<T> clazz) {
--- End diff --
these changes were something I was experimenting with... did not intend to push... will delete later
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-recipes issue #110: Reviewed APIs in prep for 1.0 release. Ma...
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on the issue:
https://github.com/apache/incubator-fluo-recipes/pull/110
I ran a 30 min test of webindex on EC2 yesterday using these changes to make sure things still spread evenly across the cluster as expected. The test was successful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---