You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Rohini Palaniswamy (JIRA)" <ji...@apache.org> on 2012/09/06 01:30:09 UTC
[jira] [Created] (PIG-2908) Fix unit tests to work with jdk7
Rohini Palaniswamy created PIG-2908:
---------------------------------------
Summary: Fix unit tests to work with jdk7
Key: PIG-2908
URL: https://issues.apache.org/jira/browse/PIG-2908
Project: Pig
Issue Type: Test
Reporter: Rohini Palaniswamy
Assignee: Rohini Palaniswamy
Priority: Minor
Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451703#comment-13451703 ]
Rohini Palaniswamy commented on PIG-2908:
-----------------------------------------
Have a patch for the tests mentioned above. Fixed tests where it was easy and for others wrote a OrderedJUnitTestRunner. But found that with new runs, more test failures came up because the order of methods seem to be random with jdk7 with different runs. Will do a few more runs next week and collect all the failures before putting up the patch. e2e tests all pass with jdk7 32 bit. So except for unit test failures pig is good with jdk7.
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Test
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476516#comment-13476516 ]
Dmitriy V. Ryaboy commented on PIG-2908:
----------------------------------------
Thanks for seeing this important but non-flashy ticket to completion, Rohini!
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Sub-task
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2908-branch10-1.patch, PIG-2908-branch10.patch, PIG-2908-trunk-1.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476533#comment-13476533 ]
Rohini Palaniswamy commented on PIG-2908:
-----------------------------------------
Yes. OrderedJunitRunner
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Sub-task
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2908-branch10-1.patch, PIG-2908-branch10.patch, PIG-2908-trunk-1.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rohini Palaniswamy updated PIG-2908:
------------------------------------
Attachment: PIG-2908-trunk.patch
PIG-2908-branch10.patch
Review:
https://reviews.apache.org/r/7176/
Steps to Run Tests:
for test in {TestLogToPhyCompiler,TestMRCompiler,TestMapSideCogroup,TestMergeJoinOuter,TestGFCross,TestJsonLoaderStorage,TestNewPlanLogToPhyTranslationVisitor}; do ant clean test -Dtestcase=$test -Dtest.output=true -logfile PIG-2908-$test-H20.log; done
cd contrib/piggybank/java
for test in {TestAvroStorage,TestCSVExcelStorage}; do ant clean test -Dtestcase=$test -Dtest.output=true -logfile PIG-2908-$test-H20.log; done
cd -
for test in {TestLogToPhyCompiler,TestMRCompiler,TestMapSideCogroup,TestMergeJoinOuter,TestGFCross,TestJsonLoaderStorage,TestNewPlanLogToPhyTranslationVisitor}; do ant clean test -Dhadoopversion=23 -Dtestcase=$test -Dtest.output=true -logfile PIG-2908-$test-H23.log; done
grep BUILD PIG-2908*
cd contrib/piggybank/java
for test in {TestAvroStorage,TestCSVExcelStorage}; do ant clean test -Dhadoopversion=23 -Dtestcase=$test -Dtest.output=true -logfile PIG-2908-$test-H23.log; done
grep BUILD PIG-2908*
For trunk, tests depending on MiniCluster will fail in H23. That requires PIG-2791 to be checked in.
Checkin Steps:
There is a new java class and svn add needs to be done.
svn add test/org/apache/pig/test/junit
There is a overlap between this patch and PIG-2405 for one test - TestNewPlanLogToPhyTranslationVisitor class. Fang has solved it by changing it to a LinkedHashMap in MapReduceOper.java and OperatorPlan.java. I have just modified tests to sort the entrySet results and then assert. If LinkedHashMap approach is preferred, I can remove TestNewPlanLogToPhyTranslationVisitor from this patch. But in general, would prefer not changing code for tests to work.
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Test
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Attachments: PIG-2908-branch10.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rohini Palaniswamy updated PIG-2908:
------------------------------------
Fix Version/s: 0.10.1
0.11
Affects Version/s: 0.10.0
Status: Patch Available (was: Open)
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Test
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2908-branch10.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476521#comment-13476521 ]
Rohini Palaniswamy commented on PIG-2908:
-----------------------------------------
Thanks Dmitriy for committing this one.
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Sub-task
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2908-branch10-1.patch, PIG-2908-branch10.patch, PIG-2908-trunk-1.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476530#comment-13476530 ]
Rohini Palaniswamy commented on PIG-2908:
-----------------------------------------
You had missed the svn add step. Can you commit the missing new test file?
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Sub-task
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2908-branch10-1.patch, PIG-2908-branch10.patch, PIG-2908-trunk-1.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rohini Palaniswamy updated PIG-2908:
------------------------------------
Status: Patch Available (was: Open)
Updated https://reviews.apache.org/r/7176/
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Test
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2908-branch10-1.patch, PIG-2908-branch10.patch, PIG-2908-trunk-1.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451685#comment-13451685 ]
Dmitriy V. Ryaboy commented on PIG-2908:
----------------------------------------
Rohini, are you planning to work on this ticket, or just raising this as an issue?
JDK7 compatibility is pretty important, it'd be great if you knocked this one out.
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Test
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-2908:
-----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to 0.11, 0.10, and trunk branches.
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Sub-task
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2908-branch10-1.patch, PIG-2908-branch10.patch, PIG-2908-trunk-1.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476534#comment-13476534 ]
Dmitriy V. Ryaboy commented on PIG-2908:
----------------------------------------
Done
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Sub-task
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2908-branch10-1.patch, PIG-2908-branch10.patch, PIG-2908-trunk-1.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated PIG-2908:
-------------------------------
Issue Type: Sub-task (was: Test)
Parent: PIG-2972
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Sub-task
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2908-branch10-1.patch, PIG-2908-branch10.patch, PIG-2908-trunk-1.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451707#comment-13451707 ]
Dmitriy V. Ryaboy commented on PIG-2908:
----------------------------------------
I haven't looked at the tests in question, but it sounds like the right solution is to make them succeed independent of the order in which tests are executed?
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Test
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476467#comment-13476467 ]
Dmitriy V. Ryaboy commented on PIG-2908:
----------------------------------------
+1 for trunk and 0.11
Why do we need to apply this to 0.10?
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Sub-task
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2908-branch10-1.patch, PIG-2908-branch10.patch, PIG-2908-trunk-1.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476475#comment-13476475 ]
Rohini Palaniswamy commented on PIG-2908:
-----------------------------------------
Dmitriy,
We have a mandate to upgrade to jdk7 by end of Nov and we are going to have 0.10.1 around for a while before 0.11 gets stabilized and we internally release 0.11. That's why need it on 0.10 too.
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Sub-task
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2908-branch10-1.patch, PIG-2908-branch10.patch, PIG-2908-trunk-1.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rohini Palaniswamy updated PIG-2908:
------------------------------------
Attachment: PIG-2908-trunk-1.patch
PIG-2908-branch10-1.patch
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Test
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2908-branch10-1.patch, PIG-2908-branch10.patch, PIG-2908-trunk-1.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rohini Palaniswamy updated PIG-2908:
------------------------------------
Status: Open (was: Patch Available)
Cancelling patch. Have few more test failures to fix after running on RHEL6+JDK7 combination. Will update the patch with fix for new test failures soon.
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Test
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2908-branch10.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451716#comment-13451716 ]
Rohini Palaniswamy commented on PIG-2908:
-----------------------------------------
That would be ideal. TestGFCross was easy to fix to run independent of the order. TestJsonLoaderStorage - first test does store, the second and third do load from data stored in first test. So I am merging the tests into one as junit does not have dependsOnMethods option like in TestNG. TestLogToPhyCompiler, TestMRCompiler depend on golden files and the order of tests is important. TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor, I think they could be fixed to be independent. The plans are different when the order of tests is different. I need to spend some more time to track that one down and fix them to succeed independent of the order.
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Test
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2908) Fix unit tests to work with jdk7
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476531#comment-13476531 ]
Dmitriy V. Ryaboy commented on PIG-2908:
----------------------------------------
test/org/apache/pig/test/junit ?
> Fix unit tests to work with jdk7
> --------------------------------
>
> Key: PIG-2908
> URL: https://issues.apache.org/jira/browse/PIG-2908
> Project: Pig
> Issue Type: Sub-task
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Priority: Minor
> Fix For: 0.11, 0.10.1
>
> Attachments: PIG-2908-branch10-1.patch, PIG-2908-branch10.patch, PIG-2908-trunk-1.patch, PIG-2908-trunk.patch
>
>
> Fix unit tests that fail when compiling with jdk7 as they depend on the order of tests run - TestGFCross, TestJsonLoaderStorage, TestLogToPhyCompiler, TestMRCompiler, TestMergeJoinOuter and TestNewPlanLogToPhyTranslationVisitor. jdk7 returns methods in a different order during reflection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira