You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "mystic-lama (via GitHub)" <gi...@apache.org> on 2023/11/25 04:46:26 UTC
[PR] ORC-994: Updated javadoc generation location outside of source tree [WIP] [orc]
mystic-lama opened a new pull request, #1663:
URL: https://github.com/apache/orc/pull/1663
### What changes were proposed in this pull request?
The PR Proposes to generate the javadoc to a location inside target folder, outside of source tree.
The location can be specified in properties inside pom.xml
### Why are the changes needed?
The changes are needed to avoid RAT check issues
### How was this patch tested?
Ran the build and manually verified the javadoc generation using `mvn javadoc:javadoc`
The javadoc's were generated inside `projectDir/target/javadoc` as configured
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-994: Updated javadoc generation location outside of source tree [orc]
Posted by "mystic-lama (via GitHub)" <gi...@apache.org>.
mystic-lama commented on PR #1663:
URL: https://github.com/apache/orc/pull/1663#issuecomment-1826387021
- Did further investigation and found that hive-storage-api had been checkin 7 years ago and most likely not dynamically generated as part of orc build.
- For the location, it's inside java/target/javadoc, proposing this as location to generate javadocs. I do not have the release experience, so we can change it as feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-994: Updated javadoc generation location outside of source tree [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #1663: ORC-994: Updated javadoc generation location outside of source tree
URL: https://github.com/apache/orc/pull/1663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-994: Updated javadoc generation location outside of source tree [WIP] [orc]
Posted by "mystic-lama (via GitHub)" <gi...@apache.org>.
mystic-lama commented on PR #1663:
URL: https://github.com/apache/orc/pull/1663#issuecomment-1826214376
This PR is WIP, not sure if the location is appropriate or not. We can update the property to reflect the final one we decide.
`hive-storage-api` docs are not being pulled in for some reason. Need to investigate this further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-994: Updated javadoc generation location outside of source tree [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1663:
URL: https://github.com/apache/orc/pull/1663#issuecomment-1837283481
This is enough for Apache ORC 2.0.0. Merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-994: Updated javadoc generation location outside of source tree [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1663:
URL: https://github.com/apache/orc/pull/1663#issuecomment-1837594282
For this part, I created ORC-1536.
> hive-storage-api docs are not being pulled in for some reason. Need to investigate this further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org