You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by s1monw <gi...@git.apache.org> on 2018/09/17 09:17:46 UTC

[GitHub] lucene-solr pull request #454: LUCENE-8503: Simplify unwrapping Filter*Reade...

GitHub user s1monw opened a pull request:

    https://github.com/apache/lucene-solr/pull/454

    LUCENE-8503: Simplify unwrapping Filter*Reader

    Today we have 3 different kinds of FilterIndexReader. While FilterDirecotryReader
    and FilterLeafReader are simple to distinguish, FilterCodecReader make decision harder
    since now we need instanceof checks to deside which unwrap method we should call. This
    adds a simple interface that allows to build generic unwrap methods to access the delegat
    of each of the filtering readers.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/s1monw/lucene-solr introduce_reader_delegate

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/454.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #454
    
----
commit b989d1fe27e3d486dd8cddf41f8265beab004e6a
Author: Simon Willnauer <si...@...>
Date:   2018-09-17T08:39:41Z

    LUCENE-8503: Simplify unwrapping Filter*Reader
    
    Today we have 3 different kinds of FilterIndexReader. While FilterDirecotryReader
    and FilterLeafReader are simple to distinguish, FilterCodecReader make decision harder
    since now we need instanceof checks to deside which unwrap method we should call. This
    adds a simple interface that allows to build generic unwrap methods to access the delegat
    of each of the filtering readers.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

[GitHub] lucene-solr pull request #454: LUCENE-8503: Call #getDelegate instead of dir...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/lucene-solr/pull/454


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org