You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/07 13:12:10 UTC

[GitHub] [fineract] vorburger opened a new pull request #997: remove bad 'default:' in SavingsEnumerations switch

vorburger opened a new pull request #997:
URL: https://github.com/apache/fineract/pull/997


   This default: is "wrong", because it's not required - the switch,
   in this particular case, *IS* actually already handling all cases.
   
   But if in the future someone were to add an additional new
   SavingsAccountTransactionType, then we would want Error Prone to
   fail to signal that it needs to be handled here - but the "default:"
   would "hide" that.
   
   This is a follow-up to https://github.com/apache/fineract/pull/983/
   for FINERACT-822, and also related to the discussion started on
   https://github.com/apache/fineract/pull/989.
   
   There originally used to be a "default:" in the middle of the switch,
   that obviously WAS completely wrong and an old copy-paste bug.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger merged pull request #997: remove bad 'default:' in SavingsEnumerations switch

Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #997:
URL: https://github.com/apache/fineract/pull/997


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #997: remove bad 'default:' in SavingsEnumerations switch

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #997:
URL: https://github.com/apache/fineract/pull/997#issuecomment-640216978


   @percyashu @awasum @thesmallstar @ptuomola


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #997: remove bad 'default:' in SavingsEnumerations switch

Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #997:
URL: https://github.com/apache/fineract/pull/997#issuecomment-640241227


   @vorburger looks good to me! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org