You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/14 15:32:09 UTC
[GitHub] [airflow] potiuk opened a new pull request #11527: Adds capability of installing wheel packages in CI image
potiuk opened a new pull request #11527:
URL: https://github.com/apache/airflow/pull/11527
The production image had the capability of installing images from
wheels (for security teams/air-gaped systems). This capability
might also be useful when building CI image espeically when
we are installing separately core and providers packages and
we do not yet have provider packages available in PyPI.
This is an intermediate step to implement #11490
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #11527: Adds capability of installing wheel packages in CI image
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #11527:
URL: https://github.com/apache/airflow/pull/11527#discussion_r504922302
##########
File path: IMAGES.rst
##########
@@ -393,12 +393,19 @@ The following build arguments (``--build-arg`` in docker build command) can be u
| ``AIRFLOW_LOCAL_PIP_WHEELS`` | ``false`` | If set to true, Airflow and it's |
| | | dependencies are installed from locally |
| | | downloaded .whl files placed in the |
-| | | ``docker-context-files``. Implies |
-| | | ``AIRFLOW_PRE_CACHED_PIP_PACKAGES`` |
-| | | to be false. |
+| | | ``docker-context-files``. |
+------------------------------------------+------------------------------------------+------------------------------------------+
| ``AIRFLOW_EXTRAS`` | ``all`` | extras to install |
+------------------------------------------+------------------------------------------+------------------------------------------+
+| ``INSTALL_AIRFLOW_VIA_PIP`` | ``false`` | If set to true, Airflow is installed via |
+| | | pip install. if you want to install |
+| | | Airflow from externaly provided binary |
Review comment:
```suggestion
| | | Airflow from externally provided binary |
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #11527: Adds capability of installing wheel packages in CI image
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #11527:
URL: https://github.com/apache/airflow/pull/11527#discussion_r504922567
##########
File path: docs/production-deployment.rst
##########
@@ -398,6 +398,15 @@ The following build arguments (``--build-arg`` in docker build command) can be u
| ``AIRFLOW_EXTRAS`` | (see Dockerfile) | Default extras with which airflow is |
| | | installed |
+------------------------------------------+------------------------------------------+------------------------------------------+
+| ``INSTALL_AIRFLOW_VIA_PIP`` | ``false`` | If set to true, Airflow is installed via |
+| | | pip install. if you want to install |
+| | | Airflow from externaly provided binary |
Review comment:
```suggestion
| | | Airflow from externally provided binary |
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11527: Adds capability of installing wheel packages in CI image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11527:
URL: https://github.com/apache/airflow/pull/11527#issuecomment-708532407
[The Workflow run](https://github.com/apache/airflow/actions/runs/306872724) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #11527: Adds capability of installing wheel packages in CI image
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11527:
URL: https://github.com/apache/airflow/pull/11527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11527: Adds capability of installing wheel packages in CI image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11527:
URL: https://github.com/apache/airflow/pull/11527#issuecomment-708590286
[The Workflow run](https://github.com/apache/airflow/actions/runs/307107015) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org