You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/24 05:30:18 UTC

[GitHub] [flink] xintongsong opened a new pull request #10673: [FLINK-15374][core][config] Update descriptions for jvm overhead config options

xintongsong opened a new pull request #10673: [FLINK-15374][core][config] Update descriptions for jvm overhead config options
URL: https://github.com/apache/flink/pull/10673
 
 
   ## What is the purpose of the change
   
   This PR updates descriptions for JVM overhead config options, to remove "I/O direct memory" and explicitly state that it's not counted into MaxDirectMemorySize.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10673: [FLINK-15374][core][config] Update descriptions for jvm overhead config options

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10673: [FLINK-15374][core][config] Update descriptions for jvm overhead config options
URL: https://github.com/apache/flink/pull/10673#issuecomment-568663453
 
 
   <!--
   Meta data
   Hash:3a8fcf0e8936f3c4115ff4771b52e060064676af Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142190071 TriggerType:PUSH TriggerID:3a8fcf0e8936f3c4115ff4771b52e060064676af
   Hash:3a8fcf0e8936f3c4115ff4771b52e060064676af Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3875 TriggerType:PUSH TriggerID:3a8fcf0e8936f3c4115ff4771b52e060064676af
   -->
   ## CI report:
   
   * 3a8fcf0e8936f3c4115ff4771b52e060064676af Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142190071) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3875) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhuzhurk commented on issue #10673: [FLINK-15374][core][config] Update descriptions for jvm overhead config options

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on issue #10673: [FLINK-15374][core][config] Update descriptions for jvm overhead config options
URL: https://github.com/apache/flink/pull/10673#issuecomment-568845069
 
 
   Thanks for opening this PR @xintongsong .
   LGTM. Merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10673: [FLINK-15374][core][config] Update descriptions for jvm overhead config options

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10673: [FLINK-15374][core][config] Update descriptions for jvm overhead config options
URL: https://github.com/apache/flink/pull/10673#issuecomment-568663453
 
 
   <!--
   Meta data
   Hash:3a8fcf0e8936f3c4115ff4771b52e060064676af Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:3a8fcf0e8936f3c4115ff4771b52e060064676af
   -->
   ## CI report:
   
   * 3a8fcf0e8936f3c4115ff4771b52e060064676af UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhuzhurk merged pull request #10673: [FLINK-15374][core][config] Update descriptions for jvm overhead config options

Posted by GitBox <gi...@apache.org>.
zhuzhurk merged pull request #10673: [FLINK-15374][core][config] Update descriptions for jvm overhead config options
URL: https://github.com/apache/flink/pull/10673
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10673: [FLINK-15374][core][config] Update descriptions for jvm overhead config options

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10673: [FLINK-15374][core][config] Update descriptions for jvm overhead config options
URL: https://github.com/apache/flink/pull/10673#issuecomment-568663453
 
 
   <!--
   Meta data
   Hash:3a8fcf0e8936f3c4115ff4771b52e060064676af Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142190071 TriggerType:PUSH TriggerID:3a8fcf0e8936f3c4115ff4771b52e060064676af
   Hash:3a8fcf0e8936f3c4115ff4771b52e060064676af Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3875 TriggerType:PUSH TriggerID:3a8fcf0e8936f3c4115ff4771b52e060064676af
   -->
   ## CI report:
   
   * 3a8fcf0e8936f3c4115ff4771b52e060064676af Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142190071) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3875) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10673: [FLINK-15374][core][config] Update descriptions for jvm overhead config options

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10673: [FLINK-15374][core][config] Update descriptions for jvm overhead config options
URL: https://github.com/apache/flink/pull/10673#issuecomment-568658483
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 3a8fcf0e8936f3c4115ff4771b52e060064676af (Tue Dec 24 05:32:18 UTC 2019)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services