You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2010/12/07 16:31:11 UTC
[jira] Created: (WICKET-3239) for stateless pages wicket complains
with "The Buffered response should be handled by
BufferedResponseRequestHandler"
for stateless pages wicket complains with "The Buffered response should be handled by BufferedResponseRequestHandler"
---------------------------------------------------------------------------------------------------------------------
Key: WICKET-3239
URL: https://issues.apache.org/jira/browse/WICKET-3239
Project: Wicket
Issue Type: Bug
Affects Versions: 1.5-M3
Reporter: Peter Ertl
when initially rendering a __stateless__ page I get
"The Buffered response should be handled by BufferedResponseRequestHandler"
it's logged by WebPageRenderer#respond(cycle) in line 185 in trunk.
I don't know if this really is worth a warning, maybe we can just remove it.
There's also method
WebPageRenderer#enableRedirectForStatelessPage()
which seems to be somehow involved (and still contains a TODO which probably should be resolved before 1.5.0)
I would like to fix it for myself but don't know much about the background of that warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3239) for stateless pages wicket complains
with "The Buffered response should be handled by
BufferedResponseRequestHandler"
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-3239:
------------------------------------
Attachment: WICKET-3239.patch
Cleaner patch.
> for stateless pages wicket complains with "The Buffered response should be handled by BufferedResponseRequestHandler"
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3239
> URL: https://issues.apache.org/jira/browse/WICKET-3239
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M3
> Reporter: Peter Ertl
> Assignee: Martin Grigorov
> Attachments: WICKET-3239.patch, WICKET-3239.patch
>
>
> when initially rendering a __stateless__ page I get
> "The Buffered response should be handled by BufferedResponseRequestHandler"
> it's logged by WebPageRenderer#respond(cycle) in line 185 in trunk.
> I don't know if this really is worth a warning, maybe we can just remove it.
> There's also method
> WebPageRenderer#enableRedirectForStatelessPage()
> which seems to be somehow involved (and still contains a TODO which probably should be resolved before 1.5.0)
> I would like to fix it for myself but don't know much about the background of that warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3239) for stateless pages wicket complains
with "The Buffered response should be handled by
BufferedResponseRequestHandler"
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3239.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M4
Fixed with r1044601
> for stateless pages wicket complains with "The Buffered response should be handled by BufferedResponseRequestHandler"
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3239
> URL: https://issues.apache.org/jira/browse/WICKET-3239
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M3
> Reporter: Peter Ertl
> Assignee: Martin Grigorov
> Fix For: 1.5-M4
>
> Attachments: WICKET-3239.patch, WICKET-3239.patch
>
>
> when initially rendering a __stateless__ page I get
> "The Buffered response should be handled by BufferedResponseRequestHandler"
> it's logged by WebPageRenderer#respond(cycle) in line 185 in trunk.
> I don't know if this really is worth a warning, maybe we can just remove it.
> There's also method
> WebPageRenderer#enableRedirectForStatelessPage()
> which seems to be somehow involved (and still contains a TODO which probably should be resolved before 1.5.0)
> I would like to fix it for myself but don't know much about the background of that warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3239) for stateless pages wicket
complains with "The Buffered response should be handled by
BufferedResponseRequestHandler"
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968794#action_12968794 ]
Martin Grigorov commented on WICKET-3239:
-----------------------------------------
The warning is there to show that BufferedResponseRequestHandler didn't handle this request for some reason.
BufferedResponseRequestHandler didn't handle it because it uses the session id as part of the key in the map of stored responses in Application. Since the page is stateless the session id is always different ...
I have no idea how to fix it for now. I'll need to debug it.
> for stateless pages wicket complains with "The Buffered response should be handled by BufferedResponseRequestHandler"
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3239
> URL: https://issues.apache.org/jira/browse/WICKET-3239
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M3
> Reporter: Peter Ertl
>
> when initially rendering a __stateless__ page I get
> "The Buffered response should be handled by BufferedResponseRequestHandler"
> it's logged by WebPageRenderer#respond(cycle) in line 185 in trunk.
> I don't know if this really is worth a warning, maybe we can just remove it.
> There's also method
> WebPageRenderer#enableRedirectForStatelessPage()
> which seems to be somehow involved (and still contains a TODO which probably should be resolved before 1.5.0)
> I would like to fix it for myself but don't know much about the background of that warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-3239) for stateless pages wicket complains
with "The Buffered response should be handled by
BufferedResponseRequestHandler"
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reopened WICKET-3239:
-------------------------------------
Reopening the ticket because the current solution has a problem - concurrent usage of the application will break because the key used for stored responses is not unique per session and if two or more users work on the same stateless page then the first one that reads it from the storedResponses will also remove it and then the request will be re-processed.
The first possible solution that comes to my mind is to pass a special parameter with unique value in the URL when redirecting and use that value as part of the key.
> for stateless pages wicket complains with "The Buffered response should be handled by BufferedResponseRequestHandler"
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3239
> URL: https://issues.apache.org/jira/browse/WICKET-3239
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M3
> Reporter: Peter Ertl
> Assignee: Martin Grigorov
> Fix For: 1.5-M4
>
> Attachments: WICKET-3239.patch, WICKET-3239.patch
>
>
> when initially rendering a __stateless__ page I get
> "The Buffered response should be handled by BufferedResponseRequestHandler"
> it's logged by WebPageRenderer#respond(cycle) in line 185 in trunk.
> I don't know if this really is worth a warning, maybe we can just remove it.
> There's also method
> WebPageRenderer#enableRedirectForStatelessPage()
> which seems to be somehow involved (and still contains a TODO which probably should be resolved before 1.5.0)
> I would like to fix it for myself but don't know much about the background of that warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3239) for stateless pages wicket complains
with "The Buffered response should be handled by
BufferedResponseRequestHandler"
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-3239:
------------------------------------
Attachment: WICKET-3239.patch
I don't see a reason why to redirect for stateless page, so I think we can remove org.apache.wicket.request.handler.render.WebPageRenderer.enableRedirectForStatelessPage() completely.
But I don't have experience with stateless components so I may miss something.
Here is a patch that fixes the problem if this redirect is really needed. It just needs to introduce a constant for "stateless-" somewhere.
> for stateless pages wicket complains with "The Buffered response should be handled by BufferedResponseRequestHandler"
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3239
> URL: https://issues.apache.org/jira/browse/WICKET-3239
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M3
> Reporter: Peter Ertl
> Attachments: WICKET-3239.patch
>
>
> when initially rendering a __stateless__ page I get
> "The Buffered response should be handled by BufferedResponseRequestHandler"
> it's logged by WebPageRenderer#respond(cycle) in line 185 in trunk.
> I don't know if this really is worth a warning, maybe we can just remove it.
> There's also method
> WebPageRenderer#enableRedirectForStatelessPage()
> which seems to be somehow involved (and still contains a TODO which probably should be resolved before 1.5.0)
> I would like to fix it for myself but don't know much about the background of that warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3239) for stateless pages wicket
complains with "The Buffered response should be handled by
BufferedResponseRequestHandler"
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970581#action_12970581 ]
Igor Vaynberg commented on WICKET-3239:
---------------------------------------
create an http session and use its id. just because you are stateless doesnt mean you cant create the session. very little overhead if you create it and dont store anything in it.
> for stateless pages wicket complains with "The Buffered response should be handled by BufferedResponseRequestHandler"
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3239
> URL: https://issues.apache.org/jira/browse/WICKET-3239
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M3
> Reporter: Peter Ertl
> Assignee: Martin Grigorov
> Fix For: 1.5-M4
>
> Attachments: WICKET-3239.patch, WICKET-3239.patch
>
>
> when initially rendering a __stateless__ page I get
> "The Buffered response should be handled by BufferedResponseRequestHandler"
> it's logged by WebPageRenderer#respond(cycle) in line 185 in trunk.
> I don't know if this really is worth a warning, maybe we can just remove it.
> There's also method
> WebPageRenderer#enableRedirectForStatelessPage()
> which seems to be somehow involved (and still contains a TODO which probably should be resolved before 1.5.0)
> I would like to fix it for myself but don't know much about the background of that warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3239) for stateless pages wicket complains
with "The Buffered response should be handled by
BufferedResponseRequestHandler"
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3239.
-------------------------------------
Resolution: Fixed
With r1045317 Wicket no more redirects after processing a stateless page.
When the page is stateless there is no bound session and there is no easy/nice way to construct a key to store the response in Application#storedResponses map. Since there is no session id, we can use a custom url parameter with temporary id that can be used in the constructed key, e.g. wicket:statelessid=asdfgh but this way the URL for all stateless pages gets "uglier". Another solution is to use a cookie to bring that key but it wont work when cookies are disabled.
> for stateless pages wicket complains with "The Buffered response should be handled by BufferedResponseRequestHandler"
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3239
> URL: https://issues.apache.org/jira/browse/WICKET-3239
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M3
> Reporter: Peter Ertl
> Assignee: Martin Grigorov
> Fix For: 1.5-M4
>
> Attachments: WICKET-3239.patch, WICKET-3239.patch
>
>
> when initially rendering a __stateless__ page I get
> "The Buffered response should be handled by BufferedResponseRequestHandler"
> it's logged by WebPageRenderer#respond(cycle) in line 185 in trunk.
> I don't know if this really is worth a warning, maybe we can just remove it.
> There's also method
> WebPageRenderer#enableRedirectForStatelessPage()
> which seems to be somehow involved (and still contains a TODO which probably should be resolved before 1.5.0)
> I would like to fix it for myself but don't know much about the background of that warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3239) for stateless pages wicket complains
with "The Buffered response should be handled by
BufferedResponseRequestHandler"
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3239:
---------------------------------------
Assignee: Martin Grigorov
> for stateless pages wicket complains with "The Buffered response should be handled by BufferedResponseRequestHandler"
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3239
> URL: https://issues.apache.org/jira/browse/WICKET-3239
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M3
> Reporter: Peter Ertl
> Assignee: Martin Grigorov
> Attachments: WICKET-3239.patch, WICKET-3239.patch
>
>
> when initially rendering a __stateless__ page I get
> "The Buffered response should be handled by BufferedResponseRequestHandler"
> it's logged by WebPageRenderer#respond(cycle) in line 185 in trunk.
> I don't know if this really is worth a warning, maybe we can just remove it.
> There's also method
> WebPageRenderer#enableRedirectForStatelessPage()
> which seems to be somehow involved (and still contains a TODO which probably should be resolved before 1.5.0)
> I would like to fix it for myself but don't know much about the background of that warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.